Clean up and enable SNES Game Genie cheatcode converter #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoshiRulz
added
the
help wanted
YoshiRulz
force-pushed
the
snes-cheat-codes
branch
from
d121e1a to
0e6d3a3
Compare
Member
Author
|
Rebased with no changes besides adding to the unit tests. Algorithm seems sane (compare Mesen), but I still have yet to find a code which works—the one in the unit test should be "infinite time" for SMW but it doesn't work. |
YoshiRulz
added
Request: Feature/Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation looked finished to me besides needing to remove the '-', but apparently it doesn't work.
resolves #3597