-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[#13054] Resolve - Enhanced recipient search selection #13408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
TszTungChau-Jo
wants to merge
12
commits into
TEAMMATES:master
from
TszTungChau-Jo:13054-enhance-recipient-typeahead-joshua
Closed
[#13054] Resolve - Enhanced recipient search selection #13408
TszTungChau-Jo
wants to merge
12
commits into
TEAMMATES:master
from
TszTungChau-Jo:13054-enhance-recipient-typeahead-joshua
+276
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring filtering - Replace dropdown with ng-bootstrap typeahead for better UX - Add substring filtering that matches anywhere in recipient names (case-insensitive) - Add click-to-show-all functionality to view all recipients - Add dropdown arrow icon for visual clarity - Fix reset behavior to restore last submitted state (not initial state) - Show all recipients on click, filter by selection only during typing - Support FLEXIBLE_RECIPIENT mode with proper state management
…recipient selection
…th specific types
…ient input fields
… selecing show section/team
|
Hi @TszTungChau-Jo, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
Contributor
|
Closing this due to inactivity, please do open it up once again once the issues are fixed and its ready for review @TszTungChau-Jo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13054
Outline of Solution
Replaced the recipient dropdown with a typeahead search component that supports substring filtering, allowing users to search recipients by typing any part of their name (case-insensitive).
Key Updates:
ngbTypeaheadfrom ng-bootstrap for autocomplete functionality with 200ms debouncesubstringFilter()method for case-insensitive substring matching anywhere in recipient namesTesting Done:
All existing unit tests pass (95 tests)
Lint and build successful
Manual testing completed:
Screenshots:

