[#13635] Migrate NEW_INSTRUCTOR_ACCOUNT_WELCOME to dynamic DB template (POC)#13636
Draft
WeeJean wants to merge 4 commits intoTEAMMATES:masterfrom
Draft
[#13635] Migrate NEW_INSTRUCTOR_ACCOUNT_WELCOME to dynamic DB template (POC)#13636WeeJean wants to merge 4 commits intoTEAMMATES:masterfrom
WeeJean wants to merge 4 commits intoTEAMMATES:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13635
Description
This PR introduces the infrastructure to decouple TEAMMATES from hardcoded, static email templates. It allows administrators to dynamically edit email templates directly from the Admin UI, starting with the
NEW_INSTRUCTOR_ACCOUNT_WELCOMEemail as a Proof of Concept (POC).Key Architectural Changes
email_templatestable in PostgreSQL (via Liquibase), along with theEmailTemplateentity andEmailTemplatesDbDAO. It uses a unique constraint on thetemplateKey.GetEmailTemplatesAction,GetEmailTemplateAction,UpdateEmailTemplateAction) routed through a newEmailTemplatesLogicsingleton to safely fetch, upsert, and revert templates.admin-email-templates-page). It features a template editor with a live HTML preview (usingDomSanitizer.bypassSecurityTrustHtmlto safely render email<style>tags).SqlEmailGeneratorto attempt fetching the template from the DB first. If no custom template exists, it safely falls back to the original static.htmlfile. The subject line is also parsed dynamically to support variables like${userName}.Why just one email?
This PR serves as a "Vertical Slice" to establish and review the Database, API, and UI architecture safely. Once this pattern is approved, the remaining ~30 static emails can easily be migrated to this new system in follow-up PRs without ballooning the scope of this initial review.
Screenshots / UI Preview
default format

revert to default option when you customise your message

Testing Done
${userName}and${joinUrl}.checkstyleMainandnpm run lint.