🛡️ Sentinel: [MEDIUM] Fix Unbounded Queue in AsyncLogger (DoS Risk)#105
🛡️ Sentinel: [MEDIUM] Fix Unbounded Queue in AsyncLogger (DoS Risk)#105TECHNICANGEL wants to merge 2 commits intomasterfrom
Conversation
🚨 Severity: MEDIUM 💡 Vulnerability: Unbounded queue in AsyncLogger (CWE-400) could lead to memory exhaustion DoS if logs are generated faster than I/O. 🎯 Impact: Application crash due to OOM during high load or infinite loops. 🔧 Fix: Implemented a bounded queue (MAX_QUEUE_SIZE = 10000) that drops messages and warns to stderr when full. ✅ Verification: Verified with `repro_logger_dos.cpp` that the application survives a message flood and prints the security warning. Co-authored-by: TECHNICANGEL <197574689+TECHNICANGEL@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removed duplicate declarations of `currentFPS` and `frameTimeMs` in `RacingEngine` class which were causing MSVC compilation error C2086. This follows up on the AsyncLogger fix to ensure the build passes. Co-authored-by: TECHNICANGEL <197574689+TECHNICANGEL@users.noreply.github.com>
TECHNICANGEL
deleted the
sentinel-async-logger-dos-fix-1605893467452341648
branch
1 participant
This PR addresses a potential Denial of Service (DoS) vulnerability in the
AsyncLoggerclass where the message queue was unbounded.Changes:
MAX_QUEUE_SIZE = 10000constant toAsyncLogger.h.log()method to check queue size before pushing.std::cerr(prints once until queue drains) to alert developers of the overflow condition without flooding logs.Verification:
repro_logger_dos.cppthat pushed 20,000 messages.[Security] AsyncLogger queue full (10000 messages). Dropping logs to prevent DoS.was printed to stderr.PR created automatically by Jules for task 1605893467452341648 started by @TECHNICANGEL