🛡️ Sentinel: [MEDIUM] Fix AsyncLogger DoS vulnerability#109
🛡️ Sentinel: [MEDIUM] Fix AsyncLogger DoS vulnerability#109TECHNICANGEL wants to merge 1 commit intomasterfrom
Conversation
🚨 Severity: MEDIUM 💡 Vulnerability: Unbounded `std::queue` in `AsyncLogger` could lead to memory exhaustion (DoS) under high load. 🎯 Impact: Application crash due to OOM if logging produces messages faster than the worker thread can consume them. 🔧 Fix: - Added `MAX_QUEUE_SIZE = 10000` to `AsyncLogger`. - Implemented logic to drop messages when queue is full. - Added thread-safe warning using `std::atomic` to alert on stderr when dropping occurs (only once per saturation event). - Fixed a compilation error in `src/main.cpp` (duplicate member variables) to enable build verification. ✅ Verification: - `cmake --build .` passes. - Verified logic in `AsyncLogger.h`. Co-authored-by: TECHNICANGEL <197574689+TECHNICANGEL@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
TECHNICANGEL
deleted the
sentinel/fix-async-logger-dos-16934021745871608156
branch
1 participant
This PR addresses a potential Denial of Service (DoS) vulnerability in the
AsyncLoggerclass by enforcing a maximum queue size.Changes:
MAX_QUEUE_SIZEconstant (10000).queueFullWarningatomic flag.log()to drop messages if the queue is full and print a warning tostd::cerr.processQueue()to reset the warning flag when the queue is drained.currentFPSandframeTimeMsto fix a compilation error that blocked verification.This aligns with the Sentinel security mandate to prevent resource exhaustion vulnerabilities.
PR created automatically by Jules for task 16934021745871608156 started by @TECHNICANGEL