-
Notifications
You must be signed in to change notification settings - Fork 6
Mobile #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Mobile #27
Changes from all commits
1fa228d
88ea9cc
bc6dad3
7be0e9e
aa74289
784bec8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,10 @@ | |
| } | ||
| } | ||
|
|
||
| @media (max-width: 960px) { | ||
| margin: 17px 0; | ||
| } | ||
|
|
||
| // .content { | ||
| // flex: 1; | ||
| // position: relative; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,22 @@ header { | |
| transition: hover-transition(border-bottom), | ||
| hover-transition(box-shadow); | ||
|
|
||
| @media (max-width: 960px){ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Space |
||
| & { | ||
| height: inherit; | ||
| } | ||
| } | ||
|
|
||
| .container { | ||
| height: 100%; | ||
| display: flex; | ||
| flex-direction: row; | ||
|
|
||
| @media (max-width: 960px) { | ||
| & { | ||
| flex-direction: column; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .brand { | ||
|
|
@@ -28,6 +40,32 @@ header { | |
| // MS Edge doesn't like unbounded SVG images. | ||
| // This value was derived empirically using Chrome 69. | ||
| max-width: 501px; | ||
|
|
||
| @media (max-width: 960px) { | ||
| & { | ||
| height: 38px; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where does this value come from? Just curious
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just experimented with different sizes and thought this fits the navbar best. |
||
| margin: 12px 0; | ||
| max-width: initial; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| button { | ||
| border: transparent; | ||
| font-size: 1.4em; | ||
| position: absolute; | ||
| right: 1.2em; | ||
| top: 0.7em; | ||
| padding: 0px; | ||
| display: none; | ||
| cursor: pointer; | ||
| background-color: transparent; | ||
|
|
||
| @media (max-width: 960px){ | ||
| & { | ||
| display: block; | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -36,6 +74,17 @@ header { | |
| display: flex; | ||
| flex-direction: column; | ||
| margin-left: 2em; | ||
|
|
||
| @media (max-width: 960px){ | ||
| & { | ||
| margin-left: 0px; | ||
| display: none; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| .nav-show { | ||
| display: block; | ||
| } | ||
|
|
||
| .cta { | ||
|
|
@@ -47,17 +96,34 @@ header { | |
| flex-direction: column; | ||
| justify-content: center; | ||
| padding-right: 1rem; | ||
|
|
||
| @media (max-width: 960px){ | ||
| text-align: left; | ||
| } | ||
| } | ||
|
|
||
| nav { | ||
| @include font(menu); | ||
|
|
||
| text-align: right; | ||
|
|
||
| @media (max-width: 960px){ | ||
| & { | ||
| text-align: left; | ||
| margin-left: 0em; | ||
| } | ||
| } | ||
|
|
||
| ul { | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: flex-end; | ||
|
|
||
| @media (max-width: 960px){ | ||
| & { | ||
| flex-direction: column; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| li { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a poor choice - adding 54kB to every page load just for a single close icon