Skip to content

Make worker kill better #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plutoless merged 1 commit into from
Jul 25, 2024
Merged

Make worker kill better #107

plutoless merged 1 commit into from
Jul 25, 2024

Conversation

@Lensual
Copy link
Contributor

@Lensual Lensual commented Jul 16, 2024 •
edited
Loading

from #78

kill -9 is not recommend, syscall.Kill SIGTERM instead of.

@sunshinexcode
Copy link
Contributor

sunshinexcode commented Jul 17, 2024

@Lensual
syscall.Kill 能正常 kill 掉进程吗? 我这边等有空了, 再验证一下, 没问题的话, 可以合入

@Lensual
Copy link
Contributor Author

Lensual commented Jul 17, 2024

@sunshinexcode
syscall.Kill 原理上和 kill 命令是一样的，但是这里我把 9 SIGKILL 换成了 15 SIGTERM 。SIGTERM 允许进程执行正常退出流程，关闭资源、完成io同步等，而SIGKILL会立即、强制杀死进程。

sunshinexcode
sunshinexcode approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@sunshinexcode sunshinexcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plutoless plutoless merged commit 7822afd into TEN-framework:main Jul 25, 2024
@sunxilin sunxilin mentioned this pull request Nov 21, 2024
Closed
BenWeekes pushed a commit that referenced this pull request Nov 12, 2025
@Lensual
feat(server): kill -9 is not recommand, syscall.Kill SIGTERM instead …
6207f53 
…of. (#107)

GREAT Thx for the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plutoless plutoless plutoless approved these changes

+1 more reviewer

@sunshinexcode sunshinexcode sunshinexcode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lensual @sunshinexcode @plutoless