fix: fontWeight and fullWidth for Wallet manager screen#1473
Merged
Conversation
Signed-off-by: clegirar <clemntgirard@gmail.com>
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
requested changes
Jan 4, 2025
Comment on lines
+65
to
+66
| <BrandText style={[fontRegular12]}>{title}</BrandText> | ||
| <BrandText style={[fontRegular16]}>{data}</BrandText> |
Collaborator
There was a problem hiding this comment.
It's a smaaaall detail, but we can remove the arrays usage is styles (I forgot too sometimes lol)
Suggested change
| <BrandText style={[fontRegular12]}>{title}</BrandText> | |
| <BrandText style={[fontRegular16]}>{data}</BrandText> | |
| <BrandText style={fontRegular12}>{title}</BrandText> | |
| <BrandText style={fontRegular16}>{data}</BrandText> |
| <NetworkIcon networkId={networkId} size={32} /> | ||
| <SpacerRow size={3} /> | ||
| <BrandText> | ||
| <BrandText style={[fontRegular16]}> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <BrandText style={[fontRegular16]}> | |
| <BrandText style={fontRegular16}> |
Collaborator
There was a problem hiding this comment.
StyleSheet usage in this file
| <View style={{ marginLeft: 16 }}> | ||
| <View> | ||
| <BrandText>{item.provider}</BrandText> | ||
| <BrandText style={[fontRegular18]}>{item.provider}</BrandText> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <BrandText style={[fontRegular18]}>{item.provider}</BrandText> | |
| <BrandText style={fontRegular18}>{item.provider}</BrandText> |
| > | ||
| {item.address} | ||
| </BrandText> | ||
| <BrandText style={[fontRegular12]}>{item.address}</BrandText> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <BrandText style={[fontRegular12]}>{item.address}</BrandText> | |
| <BrandText style={fontRegular12}>{item.address}</BrandText> |
| fontSize: 14, | ||
| }} | ||
| > | ||
| <BrandText style={[fontRegular14]}> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <BrandText style={[fontRegular14]}> | |
| <BrandText style={fontRegular14}> |
| fontSize: 14, | ||
| }} | ||
| > | ||
| <BrandText style={[fontRegular14]}> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <BrandText style={[fontRegular14]}> | |
| <BrandText style={fontRegular14}> |
Collaborator
There was a problem hiding this comment.
Please remove StyleSheet usages when you see that in your changed files
Collaborator
There was a problem hiding this comment.
StyleSheet usage in this file (pretty big)
Signed-off-by: clegirar <clemntgirard@gmail.com>
Collaborator
Author
|
Yeah it's out of scope, but we can do some PR to remove |
Signed-off-by: clegirar <clemntgirard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
fontWeightandfullWidthforWallet managerscreenIn packages/components/inputs/TextInputCustom.tsx i put a text color by default (i did the same thing than here BrandTextBase.tsx)
Before:
After:
I changed just the spacing of some style props which were many lines and could fit in one line (example here)
For the
fullWidthscreen, we are obligate to do that for the moment.But at the end, it would be great to move that in the future
ScreenContainerrefacto, and just passfullWidthtoScreenContainer, and will handle it in his scope.Else there is the changes for the entire screen 👍
Before:
After:
