feat(nft-launchpad): Add Collection Creation form front by WaDadidou · Pull Request #1477 · TERITORI/teritori-dapp

WaDadidou · 2025-01-05T20:29:52Z

more description could come soon...

Testable here: https://deploy-preview-1477--teritori-dapp.netlify.app/launchpad/apply (Teritori Testnet)
Doc draft started here: https://hackmd.io/pGHYuByvSgKfBeQ-EylSow

What's in this PR?

This PR is extracted from this one: #1024
It adds the Collection Creation form

The flow starts here:

teritori-dapp/packages/screens/Launchpad/LaunchpadApply/LaunchpadApplyScreen.tsx

Lines 79 to 89 in a8d6ccd

<OmniLink

noHoverEffect

to={{ screen: "LaunchpadCreate" }}

style={{

flex: 1,

marginHorizontal: width >= MD_BREAKPOINT ? layout.spacing_x1_5 : 0,

marginVertical: width >= MD_BREAKPOINT ? 0 : layout.spacing_x1_5,

}}

>

<LargeBoxButton {...BUTTONS[1]} />

</OmniLink>

The flow ends here:

teritori-dapp/packages/hooks/launchpad/useCreateCollection.ts

Lines 182 to 184 in 3344964

await nftLaunchpadContractClient.submitCollection({

collection,

});

I made this Zod object to pilot the Collection Creation form

teritori-dapp/packages/utils/types/launchpad.ts

Lines 80 to 153 in a8d6ccd

    
           export const ZodCollectionFormValues = z.object({ 
        
             name: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             description: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             symbol: z 
        
               .string() 
        
               .trim() 
        
               .toUpperCase() 
        
               .min(1, DEFAULT_FORM_ERRORS.required) 
        
               .refine( 
        
                 (value) => LETTERS_REGEXP.test(value), 
        
                 DEFAULT_FORM_ERRORS.onlyLetters, 
        
               ), 
        
             websiteLink: z 
        
               .string() 
        
               .trim() 
        
               .min(1, DEFAULT_FORM_ERRORS.required) 
        
               .refine((value) => URL_REGEX.test(value), DEFAULT_FORM_ERRORS.onlyUrl), 
        
             email: z 
        
               .string() 
        
               .trim() 
        
               .min(1, DEFAULT_FORM_ERRORS.required) 
        
               .refine((value) => EMAIL_REGEXP.test(value), DEFAULT_FORM_ERRORS.onlyEmail), 
        
             projectTypes: z.array(z.string().trim()).min(1, DEFAULT_FORM_ERRORS.required), 
        
             revealTime: z.number().optional(), 
        
             teamDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             partnersDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             investDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             investLink: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             artworkDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required), 
        
             coverImage: ZodLocalFileData, 
        
             isPreviouslyApplied: z.boolean(), 
        
             isDerivativeProject: z.boolean(), 
        
             isReadyForMint: z.boolean(), 
        
             isDox: z.boolean(), 
        
             escrowMintProceedsPeriod: z 
        
               .string() 
        
               .trim() 
        
               .min(1, DEFAULT_FORM_ERRORS.required), 
        
             daoWhitelistCount: z 
        
               .string() 
        
               .trim() 
        
               .min(1, DEFAULT_FORM_ERRORS.required) 
        
               .refine( 
        
                 (value) => NUMBERS_REGEXP.test(value), 
        
                 DEFAULT_FORM_ERRORS.onlyNumbers, 
        
               ), 
        
             mintPeriods: z.array(ZodCollectionMintPeriodFormValues).nonempty(), 
        
             royaltyAddress: z.string().trim().optional(), 
        
             royaltyPercentage: z 
        
               .string() 
        
               .trim() 
        
               .refine( 
        
                 (value) => !value || NUMBERS_REGEXP.test(value), 
        
                 DEFAULT_FORM_ERRORS.onlyNumbers, 
        
               ) 
        
               .optional(), 
        
             assetsMetadatas: ZodCollectionAssetsMetadatasFormValues.optional(), 
        
             baseTokenUri: z 
        
               .string() 
        
               .trim() 
        
               .refine( 
        
                 (value) => !value || isIpfsPathValid(value), 
        
                 DEFAULT_FORM_ERRORS.onlyIpfsUri, 
        
               ) 
        
               .optional(), 
        
             coverImageUri: z 
        
               .string() 
        
               .trim() 
        
               .refine( 
        
                 (value) => !value || isIpfsPathValid(value), 
        
                 DEFAULT_FORM_ERRORS.onlyIpfsUri, 
        
               ) 
        
               .optional(), 
        
           });

The data will be send onchain using the nft-launchpad contract's submit_collection:

teritori-dapp/rust/cw-contracts/nft-launchpad/src/contract.rs

Line 83 in 3c3a39e

pub fn submit_collection(

About Assets & Metadata

Use these files to test the step 6: test-files-step-6.zip
You will get these 2 warnings. It's expected, I wrongly filled the files to have these warnings as a demo.
So, you will get 3 images instead of 4 at the end.
You can fix the CSV files if you want, add assets, break the files, etc

The warnings don't block the flow, it just ignores the wrong assets.
The errors block the flow and ask the user to provide correct mapping files:

All these behaviors are handled here: https://github.com/TERITORI/teritori-dapp/blob/6ca68e031a528902d29ea9d559b466175de57902/packages/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadAssetsAndMetadata/AssetsTab.tsx
I tried to well comment the code

What after this PR?

I want to separate the front in parts

Apply - Create Collection (This PR)
Apply - My Collections + Complete Collection
Admin - Overview
Admin - Collection Review

Possible enhancement that can be done in another PRs

Add a label prop to Checkbox.
Related to chore(jsx-component): Enhance Checkbox #1481
Make MultipleSelectInput reusable (Extract it from launchpad scope).
Related to chore(jsx-component): Make a MultipleSelectInput #1482
Make a NumberInput. For now, we type numbers as string in forms and use a text input..
Related to chore(jsx-component): Make a Number input #1483
Make CurrencyInput (Extract it from launchpad scope).
Related to chore(jsx-component): Make a CurrencyInput #1484
Make Organizations/comonents/RightSection reusable (Create a reusable form wizard)
And use it in these forms: Launchpad Create, DAO Creation, Multisig Creation, ... Everytime we have a form with steps
Related to chore(jsx-component): Make a form wizard #1475

We have to write a documentation

Especialy to guide the user on this step:

We must also provide two CSV templates: Attributes mapping file and an Assets mapping file

netlify · 2025-01-05T20:30:12Z

✅ Deploy Preview for teritori-dapp ready!

Name	Link
🔨 Latest commit	`4933d03`
🔍 Latest deploy log	https://app.netlify.com/sites/teritori-dapp/deploys/67b9fde91301ae0008a7bf71
😎 Deploy Preview	https://deploy-preview-1477--teritori-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-01-05T20:30:12Z

✅ Deploy Preview for gno-dapp ready!

Name	Link
🔨 Latest commit	`4933d03`
🔍 Latest deploy log	https://app.netlify.com/sites/gno-dapp/deploys/67b9fde9632dd700089fab61
😎 Deploy Preview	https://deploy-preview-1477--gno-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MikaelVallenet

LGTM

MikaelVallenet · 2025-01-07T21:16:33Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/LaunchpadStepper.tsx

+  const hasErrors = (stepKey: number) => {
+    if (
+      (stepKey === 1 &&
+        (!!collectionForm.getFieldState("name").error ||
+          !!collectionForm.getFieldState("description").error ||
+          !!collectionForm.getFieldState("symbol").error)) ||
+      !!collectionForm.getFieldState("coverImage").error ||
+      !!collectionForm.getFieldState("assetsMetadatas.nftApiKey").error
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 2 &&
+      (!!collectionForm.getFieldState("websiteLink").error ||
+        !!collectionForm.getFieldState("isDerivativeProject").error ||
+        !!collectionForm.getFieldState("projectTypes").error ||
+        !!collectionForm.getFieldState("isPreviouslyApplied").error ||
+        !!collectionForm.getFieldState("email").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 3 &&
+      (!!collectionForm.getFieldState("teamDescription").error ||
+        !!collectionForm.getFieldState("partnersDescription").error ||
+        !!collectionForm.getFieldState("investDescription").error ||
+        !!collectionForm.getFieldState("investLink").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 4 &&
+      (!!collectionForm.getFieldState("artworkDescription").error ||
+        !!collectionForm.getFieldState("isReadyForMint").error ||
+        !!collectionForm.getFieldState("isDox").error ||
+        !!collectionForm.getFieldState("daoWhitelistCount").error ||
+        !!collectionForm.getFieldState("escrowMintProceedsPeriod").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 5 &&
+      (!!collectionForm.getFieldState("mintPeriods").error ||
+        !!collectionForm.getFieldState("royaltyAddress").error ||
+        !!collectionForm.getFieldState("royaltyPercentage").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 6 &&
+      !!collectionForm.getFieldState("assetsMetadatas").error
+    ) {
+      return true;
+    }
+  };


Do react hook form not give some methods to handle this cleaner ?
Or should we do a map[step]list of field key to just loop through the fields corresponding to the steps
like for_, val := map[step] { if !! colectionForm.getFieldState(val).error} kinda

In the return of useForm hook you have an object named formState and inside of it you have errors. I don't know what infos you have exactly but can be a solution.

const { formState: { errors } } = useForm()

But agree with @MikaelVallenet that this if forest is not very clean, and if you can't handle this with errors the map can be a better solution too

The correct way could be to just control the formState.errors yes.
I don't remember why it didn't work, but I'm checking and I'll fix.
Yes, it's messy and we need to add/remove rows from here after add/remove a field from the form...
I didn't enhanced very much this part (Stepper), because thought about this issue (Creating a reusable form wizard): #1475

I'll just fix this comment for now

Fixed: c85f0f5

MikaelVallenet · 2025-01-07T21:22:10Z

What is this about, i can choose between 1, 2 & 3

MikaelVallenet · 2025-01-07T21:26:44Z

Why would they give us some whitelist ? should we incentivize it or maybe turn this like "Teritori develop these tools with ❤️, if you appreciate it you could contribute by giving some WL spot to our DAO" this way it does not look like "we would love to have some WL to share to our DAO members" but more like you can reward use for the dev. of these tools by giving some. wdyt

MikaelVallenet · 2025-01-07T21:27:36Z

Would be nice to display the timezone to avoid misunderstandings

clegirar

In general could you please use fontRegular instead of fontMedium or fontSemiBold ? I can do it if you want 👍

About using useFormContext i think my mind can change because when you call it, you specify the type of the form so i'm not confusing when you call it, and found it better to read, it's not a lot of additional abstraction.

clegirar · 2025-01-08T10:25:16Z

packages/components/NetworkSelector/NetworkSelectorWithLabel.tsx

This component is used once and it's almost the same than MultipleSelectInput maybe you can use MultipleSelectInput instead of create an other one ?

I don't think so.
NetworkSelectorWithLabel uses NetworkSelectorMenu and its onPressNetwork and filter logic.
NetworkSelectorWithLabel is closer to NetworkSelectorMenu than MultipleSelectInput an its dropdownOptions

clegirar · 2025-01-08T10:33:28Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/LaunchpadStepper.tsx

+  const hasErrors = (stepKey: number) => {
+    if (
+      (stepKey === 1 &&
+        (!!collectionForm.getFieldState("name").error ||
+          !!collectionForm.getFieldState("description").error ||
+          !!collectionForm.getFieldState("symbol").error)) ||
+      !!collectionForm.getFieldState("coverImage").error ||
+      !!collectionForm.getFieldState("assetsMetadatas.nftApiKey").error
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 2 &&
+      (!!collectionForm.getFieldState("websiteLink").error ||
+        !!collectionForm.getFieldState("isDerivativeProject").error ||
+        !!collectionForm.getFieldState("projectTypes").error ||
+        !!collectionForm.getFieldState("isPreviouslyApplied").error ||
+        !!collectionForm.getFieldState("email").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 3 &&
+      (!!collectionForm.getFieldState("teamDescription").error ||
+        !!collectionForm.getFieldState("partnersDescription").error ||
+        !!collectionForm.getFieldState("investDescription").error ||
+        !!collectionForm.getFieldState("investLink").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 4 &&
+      (!!collectionForm.getFieldState("artworkDescription").error ||
+        !!collectionForm.getFieldState("isReadyForMint").error ||
+        !!collectionForm.getFieldState("isDox").error ||
+        !!collectionForm.getFieldState("daoWhitelistCount").error ||
+        !!collectionForm.getFieldState("escrowMintProceedsPeriod").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 5 &&
+      (!!collectionForm.getFieldState("mintPeriods").error ||
+        !!collectionForm.getFieldState("royaltyAddress").error ||
+        !!collectionForm.getFieldState("royaltyPercentage").error)
+    ) {
+      return true;
+    }
+    if (
+      stepKey === 6 &&
+      !!collectionForm.getFieldState("assetsMetadatas").error
+    ) {
+      return true;
+    }
+  };


In the return of useForm hook you have an object named formState and inside of it you have errors. I don't know what infos you have exactly but can be a solution.

const { formState: { errors } } = useForm()

But agree with @MikaelVallenet that this if forest is not very clean, and if you can't handle this with errors the map can be a better solution too

clegirar · 2025-01-08T10:38:40Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/LaunchpadStepper.tsx

+  const { width: windowWidth } = useWindowDimensions();
+  const scrollViewRef = useRef<ScrollView>(null);
+  const isMobile = useIsMobile();
+  const collectionForm = useFormContext<CollectionFormValues>();


In my refacto on react-hook-form, with norman we said to each other that don't use useFormContext to handle our form. I don't have final opinion actually on how to use it, but i just want to be consistent when we use it

Idk.
I just mention this issue here, because we are in LaunchpadStepper scope: #1475 (Form wizard)

clegirar · 2025-01-08T10:45:20Z

...pad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadAssetsAndMetadata/AssetsTab.tsx

Found this file too big.. Can't extract functions ?

I strongly commented the code because it contains the mapping files warning/errors detection.. Maybe I can extract this logic yes

I didn't figure out how to split this component...
If I add more components or files with functions, it will add more props and files juggling and adds difficulty to read.
I think it's well organized and clear when you fold the rows in IDE :/

Do you ave advises ?

(I still exported ResetAllButton to another file: cc921e8)

clegirar · 2025-01-08T10:45:53Z

...y/LaunchpadCreate/components/steps/LaunchpadAssetsAndMetadata/LaunchpadAssetsAndMetadata.tsx

+          style={[
+            fontMedium14,
+            {
+              color: neutral77,
+            },
+          ]}


Can fit in one line

As in a ton of lines in our code.
I think you should not take attention to that until we find a rule (lint + CI ?)
It could depend on the IDEs.
But we can lint by adding these lines in .eslintrc.js (These rules seem to work well):
"array-bracket-newline": ["error", "consistent"],
"object-curly-newline": ["error", "never"]

Yeah there is a lot of lines.
Okay cool maybe we could add that in a specific PR ?

Issue created: #1494

clegirar · 2025-01-08T10:46:02Z

...y/LaunchpadCreate/components/steps/LaunchpadAssetsAndMetadata/LaunchpadAssetsAndMetadata.tsx

+              fontMedium14,
+              {
+                color: primaryColor,
+              },
+            ]}


clegirar · 2025-01-08T10:49:18Z

...ges/screens/Launchpad/LaunchpadApply/components/inputs/selectInputs/SelectInputLaunchpad.tsx

Same here you can't use MultipleSelectInput ?

Actually, no, it's nor the same usage: MultipleSelectInput has Checkbox in a deep level, it's "multiple".
But...
We want to refacto this MultipleSelectInput, and add common parent(s) used in SelectInputLaunchpad and MultipleSelectInput (And extract them from NFT Launchpad, and use them in ERC20 Launchpad, etc),
But
Should we do that in this PR?

clegirar · 2025-01-08T10:54:09Z

Select file button is not centered, found that weird

WaDadidou · 2025-01-23T20:00:48Z

About using useFormContext i think my mind can change because when you call it, you specify the type of the form so i'm not confusing when you call it, and found it better to read, it's not a lot of additional abstraction.

@clegirar Your mind, but not fully about FromProvider? What was the problem with FormProvider? I think about perfomance
cc @n0izn0iz

n0izn0iz · 2025-01-23T21:02:29Z

I'm not too fond of the FormProvider because it goes against composability. What's the point of making components if they can only be used in a specific context. Contexts are good for global data but I don't see the point of using them locally

WaDadidou · 2025-01-23T21:23:34Z

I'm not too fond of the FormProvider because it goes against composability. What's the point of making components if they can only be used in a specific context. Contexts are good for global data but I don't see the point of using them locally

My main arg is just to have less props, I'm ok with yours.
Actually I don't use FormProvider only because I need it, so it's too much. It should not be a standard, but a solution for specific cases. With that in mind, I'm ok to remove its usage from this PR!

WaDadidou · 2025-01-23T21:30:32Z

Select file button is not centered, found that weird

Only in Firefox, wtf

Fixed: b01448e

WaDadidou · 2025-01-23T21:47:55Z

In general could you please use fontRegular instead of fontMedium or fontSemiBold ? I can do it if you want 👍

Done 4241965

clegirar · 2025-01-23T22:24:59Z

I don't have final opinions on react-hook-form, actually the only thing i found cool it's the zodResolver, but i found that the lib add some weird complexity.
But i prefer a way with specific props to have atomic components, than a context, for sure.
If you want to stay atomic, i think you can have a component Input and a component FormInput that handle specific props for a form.

WaDadidou · 2025-01-24T23:56:51Z

I don't have final opinions on react-hook-form, actually the only thing i found cool it's the zodResolver, but i found that the lib add some weird complexity. But i prefer a way with specific props to have atomic components, than a context, for sure. If you want to stay atomic, i think you can have a component Input and a component FormInput that handle specific props for a form.

Honestly, I'm really ok with removing react-hook-form.
But for now, I will just remove FormProvider usage from NFTLaunchpad front. I really want to merge that because I'm so done with this feature.
=> Done: 1cd87fb
After that, I'll be open to make a loooot of refactos and set up solid front patterns

… child's vertical center on Firefox

# Conflicts: # packages/screens/Launchpad/LaunchpadApply/LaunchpadApplyScreen.tsx # packages/screens/Launchpad/LaunchpadHome/LaunchpadScreen.tsx

WaDadidou · 2025-01-28T16:47:17Z

What is this about, i can choose between 1, 2 & 3

Field removed

WaDadidou · 2025-01-28T16:47:33Z

Why would they give us some whitelist ? should we incentivize it or maybe turn this like "Teritori develop these tools with ❤️, if you appreciate it you could contribute by giving some WL spot to our DAO" this way it does not look like "we would love to have some WL to share to our DAO members" but more like you can reward use for the dev. of these tools by giving some. wdyt

Field removed

WaDadidou · 2025-01-28T16:50:46Z

Would be nice to display the timezone to avoid misunderstandings

The timezone is handled at Date creation on front. The input returns a timestamp (callback), I don't see the advantage of showing the user's timezone

…aInputs)

hthieu1110

@WaDadidou thanks for your amazing works. I've left some suggestions.

hthieu1110 · 2025-02-12T07:45:45Z

packages/components/inputs/FileUploaderSmall/FileUploaderSmall.web.tsx

    const hiddenFileInputRef = useRef<HTMLInputElement>(null);
    const [hovered, setHovered] = useState(false);
    const [addedFiles, setAddedFiles] = useState<LocalFileData[]>([]);
+    const flatBoxStyle = StyleSheet.flatten(boxStyle);


why we have to flatten here :o

Here is the boxStyle type declaration: boxStyle?: StyleProp<BoxStyle>;
So it can be an array, an object, or undefined.
StyleSheet.flatten merges the styles and returns a BoStyle object in this case

hthieu1110 · 2025-02-12T08:06:54Z

packages/hooks/launchpad/useCreateCollection.ts

+              const leaves = addresses.map(keccak256);
+              const tree = new MerkleTree(leaves, keccak256);
+              const merkleRoot = tree.getRoot().toString("hex");
+              whitelist_info = {


it's a small comment but IMHO, this is JS var so we should declare it with JS convention: e.g:
const whitelistInfo = ...

Done ff8474c

hthieu1110 · 2025-02-12T08:31:16Z

packages/hooks/launchpad/useCreateCollection.ts

+          //   assetsMetadataFormsValues,
+          // );
+
+          if (!isCompleteSuccess) {


IMHO, in this case, we have already catch to handle errors so we can just throw error in case of error so all the error could be treated in the same way

Done 39ee60e

hthieu1110 · 2025-02-12T08:32:37Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadApplyScreen.tsx

+      >
+        <CustomPressable
+          onPress={() =>
+            Linking.openURL("https://airtable.com/shr1kU7kXW0267gNV")


should we put this hardcoded value to a const to make the later update easier ?

Done 33d1d16

hthieu1110 · 2025-02-12T08:34:56Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadApplyScreen.tsx

+          to={{ screen: "LaunchpadCreate" }}
+          style={{
+            flex: 1,
+            marginHorizontal: width >= MD_BREAKPOINT ? layout.spacing_x1_5 : 0,


We have several check width >= MD_BREAKPOINT and also width < MD_BREAKPOINT. So I suggest we can create: isSmallScreen = width < MD_BREAKPOINT to avoid to repeat the code and make it easier to read ^^, just my perso opinion

Done 33d1d16

hthieu1110 · 2025-02-12T08:49:19Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadBasic.tsx

+import { FileUploaderSmall } from "@/components/inputs/FileUploaderSmall";
+import { SpacerColumn } from "@/components/spacer";
+import { NetworkFeature } from "@/networks";
+import { launchpadCreateFormMaxWidth } from "@/screens/Launchpad/LaunchpadApply/LaunchpadCreate/LaunchpadCreateScreen";


check import path

Same question as #1477 (comment)

hthieu1110 · 2025-02-12T08:49:56Z

packages/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadDetails.tsx

+import { BrandText } from "@/components/BrandText";
+import { ErrorText } from "@/components/ErrorText";
+import { SpacerColumn } from "@/components/spacer";
+import { launchpadCreateFormMaxWidth } from "@/screens/Launchpad/LaunchpadApply/LaunchpadCreate/LaunchpadCreateScreen";


check import path

Same question as #1477 (comment)

hthieu1110 · 2025-02-12T08:52:39Z

...LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadMinting/ConfigureRoyaltyDetails.tsx

+
+      <TextInputLaunchpad<CollectionFormValues>
+        label="Payment Address "
+        placeHolder="teritori123456789qwertyuiopasdfghjklzxcvbnm"


just a small remark, it should be torixxxx

Yes :) Done 33d1d16

hthieu1110 · 2025-02-12T08:53:36Z

...ad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadMinting/LaunchpadMintPeriods.tsx

+  useSelectedNetworkInfo,
+} from "@/hooks/useSelectedNetwork";
+import { getNetworkFeature, NetworkFeature } from "@/networks";
+import { LaunchpadMintPeriodAccordion } from "@/screens/Launchpad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadMinting/LaunchpadMintPeriodAccordion";


check import

Same question as #1477 (comment)

hthieu1110 · 2025-02-12T08:55:03Z

...ad/LaunchpadApply/LaunchpadCreate/components/steps/LaunchpadMinting/LaunchpadMintPeriods.tsx

+
+export const LaunchpadMintPeriods: FC<Props> = ({ collectionForm }) => {
+  const networkId = useSelectedNetworkId();
+  const selectedNetwork = useSelectedNetworkInfo();


we can use: const networkId = seletectedNetwork?.id , just to have less re-render

Done 33d1d16

hthieu1110

LGTM

WaDadidou mentioned this pull request Jan 7, 2025

chore(jsx-component): Make a MultipleSelectInput #1482

Open

WaDadidou self-assigned this Jan 7, 2025

WaDadidou force-pushed the feat-launchpad-submit-collection-front branch from ce9dd57 to 2bf16bf Compare January 7, 2025 18:56

WaDadidou requested review from MikaelVallenet, Villaquiranm, clegirar, hthieu1110, n0izn0iz, omarsy and zxxma January 7, 2025 18:56

feat(launchpad): Add Collection Creation form front

6ca68e0

WaDadidou force-pushed the feat-launchpad-submit-collection-front branch from 2bf16bf to 6ca68e0 Compare January 7, 2025 19:42

MikaelVallenet reviewed Jan 7, 2025

View reviewed changes

clegirar requested changes Jan 8, 2025

View reviewed changes

fix(launchpad): remove fontSemibold

4241965

fix(launchpad): add a container level to FileUploaderSmall to fix its…

b01448e

… child's vertical center on Firefox

fix(launchpad): Add missing form in props

27f0eeb

WaDadidou mentioned this pull request Jan 25, 2025

lint: Wrap array/objects from JSX in one line if possible #1494

Open

WaDadidou added 3 commits January 25, 2025 15:46

fix(launchpad): Add missing form in props

cc921e8

fix(launchpad): Remove fields from collection creation form

845820b

Merge branch 'main' into feat-launchpad-submit-collection-front

1bc6662

# Conflicts: # packages/screens/Launchpad/LaunchpadApply/LaunchpadApplyScreen.tsx # packages/screens/Launchpad/LaunchpadHome/LaunchpadScreen.tsx

WaDadidou and others added 9 commits January 28, 2025 12:04

fix(launchpad): Remove unused stuff

c0efd84

chore(launchpad): cargo fmt

3a8f918

feat(launchpad): Change some AssetsAndMetadata warnings

bd478e4

chore: make generate

6dd5ebd

Merge branch 'main' into feat-launchpad-submit-collection-front

ba8987e

fix(launchpad): Fix error un LaunchpadMintPeriods.tsx

9f84ad4

fix(launchpad): Unique id verification in AssetsAndMetadata

43f7185

Merge branch 'main' into feat-launchpad-submit-collection-front

fe56e69

fix(launchpad): Remove one warning, fix another one (AssetsAndMetadat…

673f70f

…aInputs)

hthieu1110 reviewed Feb 12, 2025

View reviewed changes

WaDadidou and others added 7 commits February 12, 2025 10:54

chore(launchpad): rename variables

ff8474c

chore(launchpad): Add throws in hook

39ee60e

chore(launchpad): Small adjustements

33d1d16

Merge branch 'main' into feat-launchpad-submit-collection-front

cbe9031

fix(launchpad): Key in Next button

704fa0c

fix(launchpad): Make input optional

e581e04

fix(launchpad): Make input optional

54607fc

hthieu1110 approved these changes Feb 20, 2025

View reviewed changes

Merge branch 'main' into feat-launchpad-submit-collection-front

4933d03

n0izn0iz changed the title ~~feat(launchpad): Add Collection Creation form front~~ feat(erc721-launchpad): Add Collection Creation form front Feb 22, 2025

n0izn0iz changed the title ~~feat(erc721-launchpad): Add Collection Creation form front~~ feat(nft-launchpad): Add Collection Creation form front Feb 22, 2025

n0izn0iz merged commit c18215d into main Feb 22, 2025
23 of 26 checks passed

	<OmniLink
	noHoverEffect
	to={{ screen: "LaunchpadCreate" }}
	style={{
	flex: 1,
	marginHorizontal: width >= MD_BREAKPOINT ? layout.spacing_x1_5 : 0,
	marginVertical: width >= MD_BREAKPOINT ? 0 : layout.spacing_x1_5,
	}}
	>
	<LargeBoxButton {...BUTTONS[1]} />
	</OmniLink>

	await nftLaunchpadContractClient.submitCollection({
	collection,
	});

	export const ZodCollectionFormValues = z.object({
	name: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	description: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	symbol: z
	.string()
	.trim()
	.toUpperCase()
	.min(1, DEFAULT_FORM_ERRORS.required)
	.refine(
	(value) => LETTERS_REGEXP.test(value),
	DEFAULT_FORM_ERRORS.onlyLetters,
	),
	websiteLink: z
	.string()
	.trim()
	.min(1, DEFAULT_FORM_ERRORS.required)
	.refine((value) => URL_REGEX.test(value), DEFAULT_FORM_ERRORS.onlyUrl),
	email: z
	.string()
	.trim()
	.min(1, DEFAULT_FORM_ERRORS.required)
	.refine((value) => EMAIL_REGEXP.test(value), DEFAULT_FORM_ERRORS.onlyEmail),
	projectTypes: z.array(z.string().trim()).min(1, DEFAULT_FORM_ERRORS.required),
	revealTime: z.number().optional(),
	teamDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	partnersDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	investDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	investLink: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	artworkDescription: z.string().trim().min(1, DEFAULT_FORM_ERRORS.required),
	coverImage: ZodLocalFileData,
	isPreviouslyApplied: z.boolean(),
	isDerivativeProject: z.boolean(),
	isReadyForMint: z.boolean(),
	isDox: z.boolean(),
	escrowMintProceedsPeriod: z
	.string()
	.trim()
	.min(1, DEFAULT_FORM_ERRORS.required),
	daoWhitelistCount: z
	.string()
	.trim()
	.min(1, DEFAULT_FORM_ERRORS.required)
	.refine(
	(value) => NUMBERS_REGEXP.test(value),
	DEFAULT_FORM_ERRORS.onlyNumbers,
	),
	mintPeriods: z.array(ZodCollectionMintPeriodFormValues).nonempty(),
	royaltyAddress: z.string().trim().optional(),
	royaltyPercentage: z
	.string()
	.trim()
	.refine(
	(value) => !value \|\| NUMBERS_REGEXP.test(value),
	DEFAULT_FORM_ERRORS.onlyNumbers,
	)
	.optional(),
	assetsMetadatas: ZodCollectionAssetsMetadatasFormValues.optional(),
	baseTokenUri: z
	.string()
	.trim()
	.refine(
	(value) => !value \|\| isIpfsPathValid(value),
	DEFAULT_FORM_ERRORS.onlyIpfsUri,
	)
	.optional(),
	coverImageUri: z
	.string()
	.trim()
	.refine(
	(value) => !value \|\| isIpfsPathValid(value),
	DEFAULT_FORM_ERRORS.onlyIpfsUri,
	)
	.optional(),
	});

Conversation

WaDadidou commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's in this PR?

The flow ends here: teritori-dapp/packages/hooks/launchpad/useCreateCollection.ts Lines 182 to 184 in 3344964 await nftLaunchpadContractClient.submitCollection({ collection, });

I made this Zod object to pilot the Collection Creation form

About Assets & Metadata

What after this PR?

I want to separate the front in parts

Possible enhancement that can be done in another PRs

We have to write a documentation

Uh oh!

netlify bot commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for teritori-dapp ready!

Uh oh!

netlify bot commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gno-dapp ready!

Uh oh!

MikaelVallenet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MikaelVallenet commented Jan 7, 2025

Uh oh!

MikaelVallenet commented Jan 7, 2025

Uh oh!

MikaelVallenet commented Jan 7, 2025

Uh oh!

clegirar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaDadidou commented Jan 5, 2025 •

edited

Loading

The flow ends here:

teritori-dapp/packages/hooks/launchpad/useCreateCollection.ts

Lines 182 to 184 in 3344964

await nftLaunchpadContractClient.submitCollection({

collection,

});

netlify bot commented Jan 5, 2025 •

edited

Loading

netlify bot commented Jan 5, 2025 •

edited

Loading

WaDadidou Jan 23, 2025 •

edited

Loading

WaDadidou Jan 23, 2025 •

edited

Loading

WaDadidou Jan 23, 2025 •

edited

Loading

WaDadidou Jan 23, 2025 •

edited

Loading

WaDadidou Jan 25, 2025 •

edited

Loading

WaDadidou Jan 23, 2025 •

edited

Loading

WaDadidou Jan 23, 2025 •

edited

Loading

WaDadidou commented Jan 23, 2025 •

edited

Loading

n0izn0iz commented Jan 23, 2025 •

edited

Loading

WaDadidou commented Jan 23, 2025 •

edited

Loading

WaDadidou commented Jan 23, 2025 •

edited

Loading

WaDadidou commented Jan 24, 2025 •

edited

Loading