Skip to content

feat: setup cairo / starknet#1490

Merged
n0izn0iz merged 26 commits intomainfrom
feat/cairo
Feb 9, 2025
Merged

feat: setup cairo / starknet#1490
n0izn0iz merged 26 commits intomainfrom
feat/cairo

Conversation

@hthieu1110
Copy link
Collaborator

@hthieu1110 hthieu1110 commented Jan 9, 2025

  • setup Starknet structure
  • add makefile build/test scripts
  • deploy test contract
  • integrate Starknet SDK with teritori
  • integrate ArgentX wallet with teritori
  • Implement todo-list contract: add_todo, get_todos, set_todo_done
  • Add tests for todo-list contract
  • Generate ABI + client SDK for todo-list contract
  • make some call to get contract data
  • make some transaction to contract
  • gen client SDK with typechain => we can use starknet-react for now, it already has a typed client

@netlify
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 3e9428f
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/67a86bb04149fa0008ebee78
😎 Deploy Preview https://deploy-preview-1490--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit 3e9428f
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/67a86bb03468a60008be7624
😎 Deploy Preview https://deploy-preview-1490--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hthieu1110 hthieu1110 changed the title POC for Starknet feat: POC for Starknet Jan 15, 2025
@hthieu1110 hthieu1110 marked this pull request as ready for review January 15, 2025 07:36
Copy link
Collaborator

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only review front part, but sounds good for me.
Just a question, can we make this page accessible only in developerMode for the moment ? Does it make sense ?

@hthieu1110
Copy link
Collaborator Author

I can only review front part, but sounds good for me.

Just a question, can we make this page accessible only in developerMode for the moment ? Does it make sense ?

IMHO, it's not critical because this path is not accessible from any UI link so a user random cannot go there by mistake :D and in fact there is no really secret there, just my opinion

@WaDadidou
Copy link
Collaborator

The flow works, and the code seems ok.
The UI between "Add Todo" and "Connect Wallet" is not done, but it's a POC.
The starknet starknet-react and starknetkit front integration works well.


can we make this page accessible only in developerMode for the moment ? Does it make sense ?

I have two opinions:

  • Since we had put devOnly on some features, we could respect this pattern and add devOnly and developer mode handling for cairo-poc.
  • We can ignore that, and use devOnly only if some of the feature's UI are shown/reachable using the UI

hthieu1110 and others added 2 commits January 24, 2025 06:42
Co-authored-by: ๖ۣۜDadidou <50441633+WaDadidou@users.noreply.github.com>
@WaDadidou
Copy link
Collaborator

Done:

  • Tested the flow (Connect to ArgentX, connect to Starknet/Sepolia, add Todo, set Todo done)
  • Reviewed packages TS/TSX stuff

Failed:

  • Ran the Makefile commands (test.starknet, build.starknet, gen.starknet-client) locally
 scarb check
warning: unused manifest key: package.autolib
    Checking snforge_scarb_plugin v0.35.1
warning: unused manifest key: package.autolib
error: rustc 1.78.0 is not supported by the following package:
  snforge_scarb_plugin@0.35.1 requires rustc 1.80.1
error: process did not exit successfully: exit status: 101
error: could not check `snforge_scarb_plugin` due to previous error

But

 rustc --version
rustc 1.80.1 (3f5fd8dd4 2024-08-06)

Not done:

  • Reviewed abi.json, cairo stuff
  • Checked Starknet config, URLs, etc

@n0izn0iz n0izn0iz changed the title feat: POC for Starknet feat: setup cairo / starknet Feb 9, 2025
@n0izn0iz n0izn0iz merged commit 5a99dd5 into main Feb 9, 2025
23 of 25 checks passed
@n0izn0iz n0izn0iz deleted the feat/cairo branch February 9, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants