feat(gno/daokit): "resource management" handlers#1513
Merged
Conversation
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Villaquiranm
force-pushed
the
feat/add-remove-resources
branch
from
ecfd37a to
a53334b
Compare
n0izn0iz
requested changes
Feb 18, 2025
gno/p/daokit/resources.gno
Outdated
Comment on lines
44
to
56
| func NewAddResourceHandler(r *resourcesStore) MessageHandler { | ||
| return NewMessageHandler(MsgAddResourceKind, func(ipayload interface{}) { | ||
| payload, ok := ipayload.(Resource) | ||
| if !ok { | ||
| panic(errors.New("invalid payload type")) | ||
| } | ||
|
|
||
| if getResource(payload.Handler.Type()) != nil { | ||
| panic("ressource " + payload.Handler.Type() + " already exists") | ||
| } | ||
| r.setResource(payload) | ||
| }) | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| func NewAddResourceHandler(r *resourcesStore) MessageHandler { | |
| return NewMessageHandler(MsgAddResourceKind, func(ipayload interface{}) { | |
| payload, ok := ipayload.(Resource) | |
| if !ok { | |
| panic(errors.New("invalid payload type")) | |
| } | |
| if getResource(payload.Handler.Type()) != nil { | |
| panic("ressource " + payload.Handler.Type() + " already exists") | |
| } | |
| r.setResource(payload) | |
| }) | |
| } | |
| func NewSetResourceHandler(r *resourcesStore) MessageHandler { | |
| return NewMessageHandler(MsgSetResourceKind, func(ipayload interface{}) { | |
| payload, ok := ipayload.(Resource) | |
| if !ok { | |
| panic(errors.New("invalid payload type")) | |
| } | |
| r.setResource(payload) | |
| }) | |
| } |
n0izn0iz
changed the title
n0izn0iz
changed the title
n0izn0iz
reviewed
Feb 18, 2025
Collaborator
n0izn0iz
left a comment
n0izn0iz
left a comment
There was a problem hiding this comment.
when we overwrite or remove a resource, we should probably close/remove the proposals that use that resource
Signed-off-by: Norman <norman@samourai.coop>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.