Closed
Conversation
❌ Deploy Preview for gno-dapp failed.
|
❌ Deploy Preview for teritori-dapp failed.
|
n0izn0iz
requested changes
Jul 20, 2025
packages/api/api/dao/v1/dao.ts
Outdated
| @@ -0,0 +1,701 @@ | |||
| /* eslint-disable */ | |||
Collaborator
There was a problem hiding this comment.
there shouldn't be files in api/api
Collaborator
Author
There was a problem hiding this comment.
Fixed:
- Added asked
pathflag: https://github.com/TERITORI/teritori-dapp/pull/1523/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R68 - Removed
apilevel fromout: https://github.com/TERITORI/teritori-dapp/pull/1523/files#diff-10c91cb1168fcd0255be771c0387060b3b39acff43878dd86aaf468b10910f2aR8
Hm... Is it ok?
Or should we dig more and like using buf v2?
7c366f1 to
db0254e
Compare
…MATCH exception to satisfy buf lint --path api
Collaborator
|
closing in favor of #1524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make generateandmake buf.lintgive this error:So I fixed it and ran
make generate--pathflag added:outmodfied to satisfy--pathflag: https://github.com/TERITORI/teritori-dapp/blob/fix-buf-generate/buf.gen.yaml#L8DEFAULTreplaced because deprecated: https://github.com/TERITORI/teritori-dapp/blob/fix-buf-generate/buf.yaml#L7