Skip to content

Conversation

@Sabr1n4W
Copy link
Contributor

Implements #1409

Type

  • Bugfix
  • Feature
  • Documentation
  • Refactoring (e.g. Style updates, Test implementation, etc.)
  • Other (please describe):

Checklist

  • Code updated to current develop branch head
  • Passes CI checks
  • Is a part of an issue
  • Tests added for the bugfix or newly implemented feature, describe below why if not
  • Changelog is updated
  • Documentation of code and features exists

Changes

  • Added room auth request that exchanges the provided access code or token for a room auth token
    • The room auth token is used in further API requests to authenticate the user against the room
  • Removed the generation and usage of short live links to download files
    • Instead the room auth token is passed in the file access link

@Sabr1n4W Sabr1n4W self-assigned this Jan 14, 2026
@Sabr1n4W Sabr1n4W added enhancement New feature or request refactor labels Jan 14, 2026
@Sabr1n4W Sabr1n4W linked an issue Jan 14, 2026 that may be closed by this pull request
@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…tor-file-access-2

# Conflicts:
#	app/Models/Room.php
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 98.16176% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.76%. Comparing base (5f23976) to head (5641cd1).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
app/Models/RoomAuthToken.php 33.33% 4 Missing ⚠️
app/Http/Controllers/api/v1/RoomController.php 97.77% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2726      +/-   ##
=============================================
+ Coverage      96.74%   96.76%   +0.02%     
- Complexity      1823     1851      +28     
=============================================
  Files            439      443       +4     
  Lines          12478    12568      +90     
  Branches        2080     2063      -17     
=============================================
+ Hits           12072    12162      +90     
  Misses           406      406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cypress
Copy link

cypress bot commented Jan 14, 2026

PILOS    Run #2739

Run Properties:  status check passed Passed #2739  •  git commit 5641cd1fd8: Refactor file access
Project PILOS
Branch Review 1409-refactor-file-access-2
Run status status check passed Passed #2739
Run duration 07m 06s
Commit git commit 5641cd1fd8: Refactor file access
Committer Sabrina Wüst
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 611
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor file access

2 participants