fix: rename samples to seq_lens and remove dead code #1453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackXu0
commented
Jan 19, 2026
JackXu0
commented
- Rename variable 'samples' to 'seq_lens' for clarity since it holds sequence lengths
- Remove unused assignment on line 334
- Fix typo 'mirobatches' -> 'microbatches' in comment
JackXu0
force-pushed
the
fix/rename-samples-to-seq-lens
branch
3 times, most recently
from
e16e87e to
d52edc6
Compare
- Rename variable 'samples' to 'seq_lens' for clarity since it holds sequence lengths - Remove unused assignment (dead code) - Fix typo 'mirobatches' -> 'microbatches' in comments
JackXu0
force-pushed
the
fix/rename-samples-to-seq-lens
branch
from
d52edc6 to
4fa9ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.