Open
Conversation
Contributor
|
You changed the config entry layout, which means you need to provide a migration method for this. Nobody wants the configured behavior get changed unexpectedly Or you can just don't change where the whitelist / blacklist's enabled states are stored. Make it simple, and focus on the enable/disable command |
Contributor
Author
|
Ok! I will post a review here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to enable and disable a list via command.
These commands have been added:
Also added the 'enabled' option in the list configurations (whitelist.yml and blacklist.yml) and removed 'whitelist_enabled' and 'blacklist_enabled' from the main configuration.