Open
Conversation
jhnyuk
reviewed
Dec 26, 2023
Collaborator
jhnyuk
left a comment
jhnyuk
left a comment
There was a problem hiding this comment.
이번 주차도 기능 구현하시느라 수고 많으셨습니다
Collaborator
There was a problem hiding this comment.
다른 exception들이 BusinessException을 상속받는데 ErrorCode와 메시지를 함께 쓰기 위해서 인가요 ?? 의도가 궁금합니다 ㅎㅎ
Collaborator
Author
There was a problem hiding this comment.
네 맞습니다!
기존에 사용했던 방식을 그대로 고수하여 사용자 정의 ErrorCode를 활용하고자 상속하는 방식을 사용하고 있습니다!
Collaborator
There was a problem hiding this comment.
DTO 잘 작성하셨네요!
현재 코드에선 TodoDto.Request, TodoDto.ChangeStatus, TodoDto.Response가 모두 TodoDto 클래스 내에 정의되어있는데 저는 클래스로 분리해서 사용하고 있습니다
@DaTa를 붙여서 하는 방법도 있었네요 ㅎㅎ 배워갑니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
구현 내용
변경 사항
비고