Add test failure stack traces to JUnit reports#25
Open
buntagonalprism wants to merge 2 commits intoTOPdesk:mainfrom
Open
Add test failure stack traces to JUnit reports#25buntagonalprism wants to merge 2 commits intoTOPdesk:mainfrom
buntagonalprism wants to merge 2 commits intoTOPdesk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack traces were previously deliberately excluded from the JUnit output when a test failed an expectation like
expect(true, false). Stack traces were only included when an unexpected error was encountered while running the test.This change includes the stack trace in the JUnit output for test failures, as well as test errors.
An example of where stack traces for test failures may be useful: consider a large application that is using helper methods to verify common behaviour. In this case the failing expectation may not be collocated with the failing test, so having the stack trace is crucial in quickly finding where the issue is occurring.
Also swapped the escaped newline characters in the error for true newlines, which produces a cleaner output.
Fixes #14