feat: add support for protobuf 4#172
Merged
kunlin596 merged 1 commit intoTRI-ML:masterfrom May 1, 2025
Merged
Conversation
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
3 times, most recently
from
c07322a to
8633a0a
Compare
Collaborator
Author
|
@chrisochoatri please help me review, thanks! |
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
2 times, most recently
from
239641d to
f8b4850
Compare
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
5 times, most recently
from
962f62f to
185d556
Compare
kunlin596
changed the title
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
from
185d556 to
675e58f
Compare
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
8 times, most recently
from
b8d4c01 to
016704e
Compare
kunlin596
changed the title
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
5 times, most recently
from
3f3e18c to
c3cad79
Compare
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
12 times, most recently
from
b8d2cc5 to
e3d5893
Compare
kunlin596
changed the title
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
4 times, most recently
from
d87d4c0 to
794f2b5
Compare
kunlin596
changed the title
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
from
794f2b5 to
bb8c74b
Compare
Changes: 1. Update github actions base image to 22.04 since github is retiring 20.04. 2. Fix docker container build and test. 3. Update grpc tools to support protobuf 4.X.X. 4. Remove pb2 files from git tracking. 5. Bump DGP version to 2.0.0.
kunlin596
force-pushed
the
kun/feat/update-dependencies-and-project-configs
branch
from
bb8c74b to
2434272
Compare
chrisochoatri
approved these changes
May 1, 2025
Collaborator
chrisochoatri
left a comment
chrisochoatri
left a comment
There was a problem hiding this comment.
Really good addition. Thank you!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published package for testing is located in https://test.pypi.org/project/dgp/.