Accum#967
Open
dominikkiese wants to merge 31 commits intounstablefrom
Open
Conversation
Member
|
Thank you @dominikkiese for this improvement! I pushed some simplifications in my commit ffb12cc Can you please look into creating a test of the callback functionality? |
Contributor
Author
|
Commit looks good to me, using |
Wentzell
force-pushed
the
ACCUM
branch
2 times, most recently
from
227eb6a to
555eaf7
Compare
Thoemi09
force-pushed
the
ACCUM
branch
2 times, most recently
from
08fbbdb to
6e9536c
Compare
…ction to simplify code
- move functions/enums related to mean/error estimation into mean_error.hpp - update the docs - improve test coverage
- update docs - improve testing - move pdf/cdf implementation into histogram class
Co-Authored-By: Claude <noreply@anthropic.com>
Use long literals to avoid int overflow in bit shift (log_binning) and std::accumulate (lin_binning::mpi_all_gather). Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Replace the cryptic `-max_n_bins` trick in the member initializer with explicit branching per max_n_bins value. Makes the intent clear: 0 means disabled with bin_capacity=0, 1 means a single unbounded bin, other values use the provided bin_capacity. Co-Authored-By: Claude <noreply@anthropic.com>
Extract the max_n_bins_ == 1 case as an early return instead of wrapping the entire accumulation block in its negation. Reduces nesting depth and clarifies the remaining logic handles the multi-bin case. Co-Authored-By: Claude <noreply@anthropic.com>
The tol_mean, tol_err, and eps constants were declared but never used. The test body uses EXPECT_EQ (exact float comparison), not EXPECT_NEAR. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
The all_tests() CMake macro only globs *.cpp files, so the previous .hpp extension meant the StatCompatible, AccCompatible, and StatCompatibleRange concept tests were never compiled or run. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening of #966