refactor(guide-sync): migrate CF groups to include semantics and invert quality order #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReorders Radarr and Sonarr quality profile JSON definitions so that qualities and nested groups are listed in human-readable order from highest to lowest priority, while keeping the underlying structure and IDs intact for use by sync tooling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
the
Area: Backend
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
Deploying with ⚡ Cloudflare Pages
|
Contributor
Author
|
@austinwbest will need to sign off and make changes on the Notifiarr side. These changes were made based on agreements made in a Discord conversation and captured this PDR. |
rcdailey
force-pushed
the
chore/starr-reverse-quality-profile-items
branch
from
148d282 to
0d6cae4
Compare
Contributor
|
Deploying with ⚡ Cloudflare Pages
|
Contributor
Author
|
@TRaSH- I've updated the dummy json files as you requested in Discord. The GIST script is also updated. |
rcdailey
force-pushed
the
chore/starr-reverse-quality-profile-items
branch
from
0d6cae4 to
023ade8
Compare
Contributor
|
Deploying with ⚡ Cloudflare Pages
|
rcdailey
changed the title
2 tasks
Quality items now ordered highest-to-lowest priority (top-to-bottom) instead of matching API response format. Nested quality groups also reversed. Improves maintainability for guide authors. Sync tools will reverse before sending to APIs.
Delete CF groups that exclude all profiles (effectively unused). Their CFs are already embedded directly in quality profile formatItems.
These CF groups incorrectly excluded their own language profiles. French/German release groups should apply to French/German profiles.
Quality profile associations now use explicit include lists instead of exclude lists. Makes the relationship between CF groups and profiles more intuitive and maintainable.
rcdailey
force-pushed
the
chore/starr-reverse-quality-profile-items
branch
from
023ade8 to
49022df
Compare
Contributor
Author
|
Rebased onto latest main after the anime PR (#2541) merge. Verification performed:
Ready for review. |
Contributor
|
Deploying with ⚡ Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
excludetoincludesemantics for quality profilesBackground
Per TRaSH Guides Discord discussion decisions from 2025-12-30:
Include Migration: Groups now explicitly list which quality profiles receive them, rather than listing exclusions. This prevents unintended application to new profiles and makes intent clearer.
Quality Ordering: Items ordered highest-to-lowest priority (top-to-bottom) for maintainability. Sync tools will reverse before sending to APIs.
Script
Files were modified using these scripts (2 total): https://gist.github.com/rcdailey/406938848618881ea09f0ee18978e364