-
-
Notifications
You must be signed in to change notification settings - Fork 293
chore(prowlarr): Remove FlareSolverr warning #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Remove the warning that FlareSolverr is non-functional, as it currently is functioning fine.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Prowlarr FlareSolverr setup documentation by removing an outdated bug warning that stated FlareSolverr was non-functional and unlikely to be fixed, reflecting that the issue has been resolved and the tool is working again. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `docs/Prowlarr/prowlarr-setup-flaresolverr.md:13` </location>
<code_context>
-
## Install FlareSolverr
Please follow the installation instruction from [FlareSolverr](https://github.com/FlareSolverr/FlareSolverr#installation){:target="\_blank" rel="noopener noreferrer"}
</code_context>
<issue_to_address>
**issue (typo):** Use 'instructions' instead of 'instruction' for correct grammar.
This aligns with referring to a set of steps from FlareSolverr.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| ## Install FlareSolverr | ||
|
|
||
| Please follow the installation instruction from [FlareSolverr](https://github.com/FlareSolverr/FlareSolverr#installation){:target="\_blank" rel="noopener noreferrer"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Use 'instructions' instead of 'instruction' for correct grammar.
This aligns with referring to a set of steps from FlareSolverr.
|
Deploying with ⚡ Cloudflare Pages
|
|
Removing it isn't the correct way because Cloudflare has been known to actively break tools like this, so your luck may vary. So let me come up with a better suggestion in a few minutes @csandman I added a few suggestions you can include in the PR. Once that's done, I'm willing to review and approve it. Just add all three suggestions to a batch using "Add suggestion to batch," and then you can merge all three at once |
Pull Request
Purpose
I saw the warning about FlareSolverr being non-functional, but after checking the issue linked in the message (FlareSolverr/FlareSolverr#1253), it appears that it has been fixed. Also, after testing myself I can confirm that FlareSolverr is now working as expected. So, I figure that this warning is now misleading, and should be removed so people don't automatically give up on FlareSolverr as a potential solution.
Sorry if I didn't set this PR up correctly, I can adjust it if that's preferred.
Requirements
Summary by Sourcery
Documentation: