Role distribution inspection

[nike4613]

This PR adds an admin UI to inspect how and why role distribution selects certain roles, and why it distributes those roles to players.

The goal here is to assist admins in understanding the role distribution process, so they can more effectively tweak the parameters involved, and better see their effects.

This also includes a graphic showing player weights during role distribution (if derandomization is enabled) which can assist debugging that as well as help intuition when tweaking it.

Some of the graphics are a touch jank, and in particular I wish there was a good way to get an icon in the label of a collapsible form, but just role names probably works fine anyway.

This PR is based on (and soft depends-on) #1702. That dependency can be removed if necessary.

Screenshots:

[TimGoll]

Regarding my first comment, is there a reason it is disabled by default?

[nike4613]

Regarding my first comment, is there a reason it is disabled by default?

It records quite a lot of information, including lots of cloned tables, and persists them for an arbitrary amount of time. For large player counts, this could hypothetically become an issue, and I dislike silently changing behavior, even if it should be mostly transparent like this.

[TimGoll]

It records quite a lot of information, including lots of cloned tables, and persists them for an arbitrary amount of time. For large player counts, this could hypothetically become an issue, and I dislike silently changing behavior, even if it should be mostly transparent like this.

Ok, makes sense. If you think that it is too heavy, then it is probably the best. Personally I chose to enable things by default and give users the option to disable it. So they see that it is there and can disable it if they so chose

[TimGoll]

Not an in-depth review. I might take another look at your derma code. But overall this looks pretty good to me. You have a few blobs of dead code in your code, which should be removed. Also either tackle the ToDos, or remove them

[TimGoll]

Mostly just minor nitpicks that build on top stuff already pointed out.

Don't get me wrong, because I'm really impressed by the stuff you did here, but most of my comments are about stuff you are able to spot yourself in 10 minutes when scrolling through the diff. This could have been quicker for you, if you removed any dead code :D

Thank you!

[TimGoll]

From my POV this PR is good as it is now. Since this is a rather big PR, I'd like a quick ok from @Histalek or @saibotk here as well. You don't have to review this in depth, but please give it a quick scroll through

[Histalek]

the function typo needs fixing, otherwise this seems good to go :)

Amazing work!