vGui: Fixed Clientside ConVars & Small Misc Fixes#1742
Merged
Conversation
TimGoll
added
the
skip-changelog
TimGoll
changed the title
saibotk
approved these changes
Jan 25, 2025
Histalek
pushed a commit
to WardenPotato/TTT2
that referenced
this pull request
Jan 31, 2025
fixes TTT-2#1735 This issue was created since the cvar is now tracked in the "main button" not the checkbox button anymore. This worked fine for serverside settings with custom handling, as well as client settings that use function wrappers to set the convar (like vskin for example). This change now correctly sets the stored convar. It feels a bit hacky to me to be honest, but only a full rewrite would resolve this. So it is probably fine. I also noticed that [this requested change](TTT-2#1724 (comment)) was not applied to all function calls, so I renamed the one remaining. Last but not least, I noticed that the border radius was substracted twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1735
This issue was created since the cvar is now tracked in the "main button" not the checkbox button anymore. This worked fine for serverside settings with custom handling, as well as client settings that use function wrappers to set the convar (like vskin for example).
This change now correctly sets the stored convar. It feels a bit hacky to me to be honest, but only a full rewrite would resolve this. So it is probably fine.
I also noticed that this requested change was not applied to all function calls, so I renamed the one remaining.
Last but not least, I noticed that the border radius was substracted twice.