Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing TTT-2/ttt2-wep_identity_disguiser#15 I noticed an issue with overhead icons.
For example if someone disguised himself as a Detective he wouldn't have an overhead icon.
The Identity Disguiser uses
TTT2ModifyOverheadIconand correctly returnsshouldDraw = truewith valid material/color.However the icon was still not rendered because
shouldDrawDefaultwas false and the check incl_targetid.luafiltered it out.I adjusted the condition so that
shouldDraw = trueis respected even whenshouldDrawDefaultis false.After I tested it again the disguised players now show overhead icons correctly and the default behavior remains the same (Detectives, teammates, ...).