chore: Small improvements in the docker-compose setup #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natkam
commented
Oct 15, 2025
natkam
force-pushed
the
docker-improvements
branch
from
ca0b3e0 to
67729c1
Compare
florian-jaeger
approved these changes
Oct 17, 2025
natkam
force-pushed
the
docker-improvements
branch
from
58a6b12 to
22d3dfd
Compare
- remove the network used by all containers (dc creates it by default) - set default DATABASE_TYPE to sqlite => simpler dc up commands - change restart policy to unless-stopped => containers don't restart after system restart (which was annoying in local development)
`E'\n'` is invalid syntax in sqlite. It was used in `replace(<very long logs as a string>, '\n', E'\n')` and `replace(<very long logs as a string>, '\012', E'\n')`. I just replaced these values (`\n` and `\012`) with newlines.
We don't include the submission files and repos in the initial setup, and creating the database objects without them doesn't make much sense, because one cannot do anything with such submissions in grader service.
natkam
force-pushed
the
docker-improvements
branch
from
16fe68d to
b72014a
Compare
Contributor
Author
|
@florian-jaeger Ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
data_only.sqlfile (missinguser_idafter db migration), remove some of the objects (see below for details), and add directories with initial repos (source and release files for the initial assignment)The docker compose setup works, both for sqlite and psql. The initial data is imported into the db in both variants, and the
sourceandreleaserepositories are created.I've removed some of the assignments (among them, the deleted ones) and all the submissions from the initial data. My reasoning is that on the one hand, it's going to be easier to maintain the initial data when we load less objects; on the other hand, the repo directories tend to get heavy, so this also has the advantage of keeping the initial data size as small as possible.