Mark test_bad_queries and test_good_queries as ignored#2774
Merged
CommanderStorm merged 2 commits intomainfrom Mar 12, 2026
Merged
Mark test_bad_queries and test_good_queries as ignored#2774CommanderStorm merged 2 commits intomainfrom
CommanderStorm merged 2 commits intomainfrom
Conversation
Co-authored-by: CommanderStorm <26258709+CommanderStorm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ignore bad and good queries tests due to flakiness
Mark test_bad_queries and test_good_queries as ignored
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables two Meilisearch-backed query-quality tests in the server search executor by marking them as ignored, due to flakiness.
Changes:
- Mark
test_good_queriesas ignored with a flakiness note. - Mark
test_bad_queriesas ignored with a flakiness note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_good_queriesandtest_bad_queriesare flaky over time and provide low signal, so they should not run by default.Proposed Change(s)
#[ignore = "flaky over time and low signal"]to bothtest_good_queriesandtest_bad_queriesinserver/src/search_executor/mod.rsTests can still be run explicitly via
cargo test -- --ignoredwhen needed.Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.