feat: refactor the search API to use query params for the filters instead of "natural language"#2872
Merged
CommanderStorm merged 19 commits intoTUM-Dev:mainfrom Apr 25, 2026
Conversation
for more information, see https://pre-commit.ci
- Add version: 10.14.0 back (needed for pnpm/action-setup to install the correct version) - Remove sha512 hash from tests/package.json packageManager to avoid version mismatch with the action's version parameter - Use run_install + package_json_file to match the working webclient CI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CommanderStorm
force-pushed
the
query-based-search-api
branch
from
ecd6bad to
149aa87
Compare
pnpm's `manage-package-manager-versions` feature causes it to prepend its own binary dependencies as a separate YAML document into the lockfile. This creates a "multiple documents in stream" parse error when other pnpm instances read the lockfile. Adding `manage-package-manager-versions=false` to .npmrc in both webclient/ and tests/ disables this behavior. Also reverts the corrupted lockfile from the previous autofix commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ofix The `run_install` option in pnpm/action-setup triggers pnpm's manage-package-manager-versions feature, which prepends self-managed binary deps as a separate YAML document into the lockfile. The autofix-ci action then commits this corrupted lockfile. Switch back to separate `pnpm install` shell steps (with package_json_file to ensure the correct version) so pnpm doesn't modify the lockfile, and autofix-ci has nothing spurious to commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When pnpm is invoked as a shell command, it resolves to a different binary than the one installed by pnpm/action-setup, causing lockfile parse errors. Using run_install ensures the action's own pnpm binary is used (matching the pattern in webclient-cicd.yml which passes). The .npmrc with manage-package-manager-versions=false (added in a previous commit) prevents run_install from writing self-managed deps into the lockfile. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pnpm's manage-package-manager-versions feature modifies the lockfile even with --frozen-lockfile, prepending self-managed binary deps. Since autofix-ci commits all changes, this corruption gets pushed. Restore the lockfiles with git checkout before autofix-ci runs so only intentional changes (updated types, snapshots, etc.) are committed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The Playwright webServer has a 120s timeout for docker compose up, which isn't enough to build from scratch in CI. Pre-build the Docker images (matching the E2E workflow) so the timeout only covers startup. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
`web::Query` uses `serde_urlencoded`, which fails to deserialize `Vec<String>` from repeated keys (e.g. `?in=garching&in=5304`), returning 400. Add a `FromRequest` impl for `SearchQueryArgs` that uses `serde_html_form` to handle repeated keys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The custom `FromRequest` impl bypasses utoipa-actix-web's auto-detection that `web::Query<T>` means query params, so utoipa was generating the spec with `in: path` and `required: true` for every field. Annotate the struct with `#[into_params(parameter_in = Query)]` so the spec stays correct. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CommanderStorm
commented
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.