Implement lin_to_quad for wedges and to_serendipity#10
Merged
amgebauer merged 1 commit intoTUM-LNM:mainfrom Sep 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements comprehensive mesh adaptation functionality by adding support for wedge elements in linear-to-quadratic conversion and introducing a new serendipity element conversion feature. The implementation refactors the existing lin_to_quad function to use a more flexible architecture based on an adaptable scheme pattern.
- Refactored mesh adaptation using a generalized
adapt_meshfunction with customizable adapting schemes - Added support for wedge elements (3D triangular prisms) in linear-to-quadratic conversion
- Implemented
to_serendipityfunction for converting hexahedral elements to 20-node serendipity elements
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/biomesh/adapt.py | Core implementation of refactored adaptation architecture and new serendipity conversion |
| tests/test_adapt.py | Added comprehensive test coverage for hex8→hex27, tet4→tet10, and hex8→hex20 conversions |
| tests/data/*.vtu | Added reference mesh files for validating adaptation algorithms |
| pyproject.toml | Version bump to 0.6.0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0a209f4 to
fb24155
Compare
davidrudlstorfer
previously approved these changes
Sep 2, 2025
davidrudlstorfer
left a comment
There was a problem hiding this comment.
Nice features :)
Only optional feedback
fb24155 to
a175f52
Compare
davidrudlstorfer
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.