Skip to content

Implement lin_to_quad for wedges and to_serendipity#10

Merged
amgebauer merged 1 commit intoTUM-LNM:mainfrom
amgebauer:add-lin-to-quad-for-wedges-and-to_serendipity
Sep 2, 2025
Merged

Implement lin_to_quad for wedges and to_serendipity#10
amgebauer merged 1 commit intoTUM-LNM:mainfrom
amgebauer:add-lin-to-quad-for-wedges-and-to_serendipity

Conversation

@amgebauer
Copy link
Contributor

No description provided.

@amgebauer amgebauer requested a review from Copilot September 2, 2025 13:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements comprehensive mesh adaptation functionality by adding support for wedge elements in linear-to-quadratic conversion and introducing a new serendipity element conversion feature. The implementation refactors the existing lin_to_quad function to use a more flexible architecture based on an adaptable scheme pattern.

  • Refactored mesh adaptation using a generalized adapt_mesh function with customizable adapting schemes
  • Added support for wedge elements (3D triangular prisms) in linear-to-quadratic conversion
  • Implemented to_serendipity function for converting hexahedral elements to 20-node serendipity elements

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

File Description
src/biomesh/adapt.py Core implementation of refactored adaptation architecture and new serendipity conversion
tests/test_adapt.py Added comprehensive test coverage for hex8→hex27, tet4→tet10, and hex8→hex20 conversions
tests/data/*.vtu Added reference mesh files for validating adaptation algorithms
pyproject.toml Version bump to 0.6.0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@amgebauer amgebauer force-pushed the add-lin-to-quad-for-wedges-and-to_serendipity branch from 0a209f4 to fb24155 Compare September 2, 2025 13:13
@amgebauer amgebauer enabled auto-merge September 2, 2025 13:15
Copy link

@davidrudlstorfer davidrudlstorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice features :)

Only optional feedback

@amgebauer amgebauer force-pushed the add-lin-to-quad-for-wedges-and-to_serendipity branch from fb24155 to a175f52 Compare September 2, 2025 13:48
@amgebauer amgebauer merged commit afa45fe into TUM-LNM:main Sep 2, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants