Implement simple Laplace solver and some related utilities#8
Merged
amgebauer merged 10 commits intoTUM-LNM:mainfrom Aug 29, 2025
Merged
Implement simple Laplace solver and some related utilities#8amgebauer merged 10 commits intoTUM-LNM:mainfrom
amgebauer merged 10 commits intoTUM-LNM:mainfrom
Conversation
7c4ad2a to
dee9c0e
Compare
davidrudlstorfer
left a comment
There was a problem hiding this comment.
Actually just a lot of questions/ideas on the coding style.
If the tests of the implemented FE methods lead to the correct results I hope that the implementation is correct as well :D
dee9c0e to
1fcfaf4
Compare
1fcfaf4 to
f53c009
Compare
f53c009 to
06d7370
Compare
davidrudlstorfer
left a comment
There was a problem hiding this comment.
Really nice changes 😍
The src layout is pretty nice and I really like the slimmed down and uniform docstrings. Also really nice, that a lot of the basic functionality was outsourced to symfem. And last but not least, the vtu files look much nicer if they are readable. Nice improvements!
06d7370 to
2ec3bb6
Compare
davidrudlstorfer
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a basic Laplace solver and some utility functions that are useful for computing spatially varying fibers in the context of rule-based methods. This includes:
Additionally, this enhances the README with many needed info for a quick start.