-
-
Notifications
You must be signed in to change notification settings - Fork 1
ニフラムトラップの変更と1.21.4移植 #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ニフラムトラップの変更と1.21.4移植 #971
Conversation
NePonpon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
デバッグ用のコマンド削除をお願いします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
NePonpon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
スコアボードを直してほしいです
| # ニフラムトラップ毎tick処理 | ||
|
|
||
| # 計算結果を取得 | ||
| execute store result score _ Calc run scoreboard players get @s Level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これ要らないんじゃないかな
直接 @s Levelで比較してもいいと思う
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
NePonpon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okです
チケット URL
GH-970
対応内容・対応背景・妥協点
ニフラムトラップを変更して1.21.4に移植した。
やったこと
・サウンドソースの変更
・演出をルカナントラップと同じように変更
・レベルの保存方法を変更
やってないこと
トラップの実行順が元々後ろにあるが、現在は狩人スキルと同じ場所にある。ボミオスがマージされ次第コンフリクトと共に修正する予定。
チェックリスト (ガイドライン)