フォトニックレーザーの1.21.4移植 #978
Merged
フォトニックレーザーの1.21.4移植 #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NePonpon
requested changes
Nov 21, 2025
Member
NePonpon
left a comment
NePonpon
left a comment
There was a problem hiding this comment.
抑制設定を偶数にしていると見えるタイミングと見えないタイミングに二分されてしまって抑制の意味がないので、ここでShowParticlesはいらないかな
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケット URL
GH-977
対応内容・対応背景・妥協点
フォトニックレーザーを1.21.4に移植した。
やったこと
・サウンドソースの変更
・ダメージ処理の呼び出しをPortalCooldown依存のタイミングに変更、これに伴ってプレディケートを追加
・ファイル名の不要な数字を削除
やってないこと
・演出の変更 マクロ化・Showparticlesの適用をするべきか不明なため見送っています
テスト
正常に発動、演出が機能し、一秒ごとに想定したダメージを与えられた。
チェックリスト (ガイドライン)