アレイズの変更と1.21.4移植 #991
Open
アレイズの変更と1.21.4移植 #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケット URL
GH-839
対応内容・対応背景・妥協点
アレイズの仕様を変更して1.21.4に移植した。
やったこと
AnywhereTPを代替処理にした
パーティクルとサウンドソースの変更
AECの演出を約3/4に短縮
やってないこと
・復活酔いの実装（デバフとして実装するため）
・RaisePoint残留の対処
・ボス側でのボス戦フラグの付与、RaisePointの削除
テスト
・ディメンションをまたぐ復活が正常に行える。
・エラーとなる条件で失敗処理が実行される。
レビュー観点
補足
デバッグ用（ストレージ名は暫定）
レイズ失敗時にレイズポイントが3分間も残ってしまう。これをどう対処するか（レイズ側での対処ではなく、ボス戦開始時にRaisePointをすべて削除してしまってもいいかも？）ボス戦処理の方で対処する方針で
チェックリスト (ガイドライン)