-
Notifications
You must be signed in to change notification settings - Fork 2
Modern redesign of entire website #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Very exciting! I'll check sometime next week. I might have some minor wording suggestions. |
Oh damn I forgot that I was hosting a file there for TUfast, I took that server down last week or so. Do you remember what file was hosted/pulled from there? Maybe I still have it and can provide it to you so that you can find another way to integrate the photo into the webapp. |
|
It was your profile picture, we could use your github profile picture link instead |
|
Very good! I really like the modern look and design choices. I will leave a few comments:
I just looked at this during a train ride and had internet the entire time 🚆 |
|
Hi Oli, thanks for reviewing! I addressed all your comments.
By the way, internet during the entire train ride? Sounds like a story from the Paulaner Garden |
|
I wasn't entirely happy with the hero section myself, so no worries bringing it up again! I experimented a little bit and created a few variations. I know you liked the line with the short info, but it was just not in the right place. My favourite is Layout 2, Text 4 – only „von Studierenden“. What do you think? https://drive.google.com/drive/folders/1kGNVRk_cQtnzEX6ej7F0Ef21upElHhxc?usp=sharing For line breaking and window size issues, I think we will be able to handle that just fine with CSS. :) |
|
Alright, cool. I think all of the versions are fine, as the purpose of TUfast is immediately clear on all of them. My favs are I think that for L2 the "Jetzt auch für FF mobile" is maybe a bit too prominent, even above the main title and with the flame. It might be a bit slightly better fitting as in L1 to the other available browser, as the user would expect it there. I'd definetly keep the flame in any case. |
|
I adjusted the hero design according to our favs. Line breaks look good now as well. |
|
If you ever need a reference for Deutschlandstipendium or something let me know. |



Description
I propose the following changes in my PR:
References
I like to design stuff, so I designed this to look more modern and fun.
Changes in detail
On that note: @Noxdor Your image is not available from your site anymore.
On that note: I'm working on a update of the settings page and implemented tabler icons there as well, since they allow importing them globally.
Testing
I tested my changes on Chrome and Firefox, both on desktop.
Couldn't test on mobile, only checking with dev tools responsive-tool.