fix: router interface is wrong correct is site matcher#6416
Open
BreathCodeFlow wants to merge 1 commit intoTYPO3-Documentation:mainfrom
Open
fix: router interface is wrong correct is site matcher#6416BreathCodeFlow wants to merge 1 commit intoTYPO3-Documentation:mainfrom
BreathCodeFlow wants to merge 1 commit intoTYPO3-Documentation:mainfrom
Conversation
See \TYPO3\CMS\Frontend\Middleware\SiteResolver
Member
|
The SiteMatcher is internal while the RouterInterface can be publicly used therefore I would suggest to stick with the RouterInterface here |
Author
Yes, this is correct; however, if you import the RouterInterface, the code breaks. The RouterInterface requires the Site, but the dependency injection (DI) does not import it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See \TYPO3\CMS\Frontend\Middleware\SiteResolver