Skip to content

Conversation

@HimanshuRamavat07
Copy link
Contributor

The "Loading JavaScript in TypoScript" section incorrectly placed includeJSFooter inside includeCSS, which is not valid TypoScript. JavaScript includes must be placed under includeJSFooter, not includeCSS.

This update corrects the example and prevents confusion for integrators.

Copy link
Member

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching!

@linawolf linawolf merged commit 669549e into TYPO3-Documentation:13.4 Nov 28, 2025
5 checks passed
@github-actions
Copy link
Contributor

The backport to 13.4 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

stdout
On branch backport-1653-to-13.4
You are currently cherry-picking commit aea1bb8b.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-1653-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick aea1bb8b57f6cf86ffe4f5871eaafb69573bb649
# Push it to GitHub
git push --set-upstream origin backport-1653-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4

Then, create a pull request where the base branch is 13.4 and the compare/head branch is backport-1653-to-13.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done Changes have been backported to other branches already

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants