Correct Bookmark Icon Functionality Description #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bookmarks are added under share icon not by clicking the star
Remove extra space
froemken
reviewed
Apr 16, 2025
Documentation/Concepts/Backend/GeneralBackendStructure/TopBar/Index.rst
Outdated
Show resolved
Hide resolved
Contributor
|
Hi @heidi37 thank you for providing this patch. I have just added a comment to your patch. Nevertheless I have a problem with Can you update your patch accordingly? Thank you Stefan |
… bookmark feature
Contributor
Author
|
Hi @froemken, I changed the patch to match your suggestion. Thank you! |
froemken
approved these changes
Apr 16, 2025
Contributor
|
Hi @heidi37 thank you for that update. I will try to migrate your patch back to TYPO3 13 and 12. Stefan |
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add a bookmark you need to use Share Icon menu dropdown in the DocHeader. Clicking on the star doesn't bookmark a page.