Skip to content
This repository was archived by the owner on May 4, 2021. It is now read-only.

Conversation

markusguenther
Copy link

  • adjusting some php docs
  • remove an unused variable $pageId in the getHeader method. It was also duplicated because itemId will be equal to the pageId in the page indexer
  • Prevent warnings while indexing pages. The pages will be logged with errors so why should i see the warning in the scheduler?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use the @ silencer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in this case you will get warnings in the backend and this is also not so nice ... you will see the error later in the backend module or devlog.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants