[TASK] Avoid value decoding in DataSet::import()
#687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuerk
force-pushed
the
stefan-3
branch
4 times, most recently
from
edc4384 to
7a6da0d
Compare
TYPO3 v14 no longer converts values to database values when using `Connection::insert()`, which makes decoding values from CSV DataSet files an error. One solution would be to pass the argument to enforce converting values again, which is used here. This is possible since an early introduction of the method argument with [1] and becomes mandantory with [2] flipping the default value. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/89293 [2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/90957 Releases: main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPO3 v14 no longer converts values to database values
when using
Connection::insert(), which makes decodingvalues from CSV DataSet files an error.
One solution would be to pass the argument to enforce
converting values again, which is used here.
This is possible since an early introduction of the
method argument with [1] and becomes mandantory with
[2] flipping the default value.
[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/89293
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/90957
Releases: main