Skip to content

Update Index.rst#27

Open
yannickpschroeder wants to merge 3 commits intoTYPO3GmbH:developfrom
yannickpschroeder:develop
Open

Update Index.rst#27
yannickpschroeder wants to merge 3 commits intoTYPO3GmbH:developfrom
yannickpschroeder:develop

Conversation

@yannickpschroeder
Copy link

Corrected wrong documentation! Key in javascript configuration "dataProcessingService" should be "dataServiceProcessor".

Corrected wrong documentation!
@andreaskienast
Copy link
Member

Thank you for your pull request. Can you please elaborate why you think the configuration is wrong? At least in the develop branch, dataServiceProcessor is deprecated in favor of dataProcessingService.

@andreaskienast andreaskienast added the question Further information is requested label Jan 7, 2021
@yannickpschroeder
Copy link
Author

yannickpschroeder commented Jan 8, 2021

When people find this extension at https://extensions.typo3.org/extension/usercentrics/ and install it via composer with composer req t3g/usercentrics the latest version will be installed, in which dataProcessingService does not exist. At extensions.typo3.org you click on Extension Manual and then on Usage. The given example didn't work for me. So I had to check the Github Repository to find out that "dataProcessingService" will be used in future, but at the moment only "dataServiceProcessor" works for me.

@andreaskienast
Copy link
Member

So this PR relates to already released versions only. Thanks for clarification, I'll re-check this ASAP.

Added warning instead of changing the argument name.
@yannickpschroeder
Copy link
Author

You are totally right. Maybe just adding a warning is the better way than changing the argument name.

@andreaskienast andreaskienast force-pushed the develop branch 2 times, most recently from 72b2606 to e0dedbc Compare February 19, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants