Skip to content

fix: display translations for thumbnail size combobox options #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Math-Bee wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: display translations for thumbnail size combobox options #1290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2f4e52
fix: use translations for thumbnail size combobox
Math-Bee Dec 18, 2025
6504c01
Merge remote-tracking branch 'upstream/main' into quickfix
Math-Bee Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions src/tagstudio/qt/views/main_window.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,14 +443,6 @@ def rebuild_open_recent_library_menu(

# View Component
class MainWindow(QMainWindow):
THUMB_SIZES: list[tuple[str, int]] = [
(Translations["home.thumbnail_size.extra_large"], 256),
(Translations["home.thumbnail_size.large"], 192),
(Translations["home.thumbnail_size.medium"], 128),
(Translations["home.thumbnail_size.small"], 96),
(Translations["home.thumbnail_size.mini"], 76),
]

def __init__(self, driver: "QtDriver", parent: QWidget | None = None) -> None:
super().__init__(parent)
self.rm = ResourceManager()
Expand Down Expand Up @@ -669,8 +661,11 @@ def setup_extra_input_bar(self):
self.thumb_size_combobox.setMinimumWidth(128)
self.thumb_size_combobox.setMaximumWidth(352)
self.extra_input_layout.addWidget(self.thumb_size_combobox)
for size in MainWindow.THUMB_SIZES:
self.thumb_size_combobox.addItem(size[0], size[1])
self.thumb_size_combobox.addItem(Translations["home.thumbnail_size.extra_large"], 256)
self.thumb_size_combobox.addItem(Translations["home.thumbnail_size.large"], 192)
self.thumb_size_combobox.addItem(Translations["home.thumbnail_size.medium"], 128)
self.thumb_size_combobox.addItem(Translations["home.thumbnail_size.small"], 96)
self.thumb_size_combobox.addItem(Translations["home.thumbnail_size.mini"], 76)
self.thumb_size_combobox.setCurrentIndex(2) # Default: Medium

self.central_layout.addLayout(self.extra_input_layout, 5, 0, 1, 1)
Expand Down