Skip to content

refactor: separate wait step from PR comment step#21

Merged
TaiSakuma merged 1 commit intomainfrom
refactor/separate-wait-step
Mar 22, 2026
Merged

refactor: separate wait step from PR comment step#21
TaiSakuma merged 1 commit intomainfrom
refactor/separate-wait-step

Conversation

@TaiSakuma
Copy link
Owner

Summary

  • Split the deployment polling into its own "Wait for deployment" step
  • Extract magic numbers into maxAttempts and intervalMs variables
  • The wait step outputs live (true/false), used by the comment step to add a note if the site isn't ready

Test plan

  • PR preview comment appears after deployment is live
  • No "not ready" note under normal conditions

🤖 Generated with Claude Code

Split the polling logic into its own step and extract magic numbers
into named variables.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot added the refactor Code refactoring label Mar 22, 2026
github-actions bot added a commit that referenced this pull request Mar 22, 2026
@github-actions
Copy link
Contributor

@TaiSakuma TaiSakuma merged commit a8ada51 into main Mar 22, 2026
4 checks passed
@TaiSakuma TaiSakuma deleted the refactor/separate-wait-step branch March 22, 2026 11:25
github-actions bot added a commit that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant