Clarify task deletion logic in search index scheduling

[Copilot]

Addressed review feedback on PR #1044 regarding the task deletion condition logic in SearchIndexService.updateSearchIndexAndTask$().

Context

The automated reviewer flagged this condition as potentially incorrect:

if (!searchIndex.schedule || searchIndex.schedule.cronExpression || !searchIndex.schedule.uuid) {
  return this.updateSearchIndex$(id, searchIndex);
}

Suggesting it should check for !searchIndex.schedule.cronExpression instead.

Resolution

@mprins confirmed the current logic is correct. The condition appropriately:

• Skips task deletion when setting/updating a schedule (cronExpression is truthy)
• Triggers task deletion only when clearing a schedule (cronExpression is falsy with existing uuid)

No code changes required - this PR documents the clarification for the review thread.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.