More checkstyle

Author: merlimat

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BatchedReadCompletion.java

@@ -22,6 +22,7 @@
 package org.apache.bookkeeper.proto;
 
 import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
+
 import org.apache.bookkeeper.client.BKException;
 import org.apache.bookkeeper.util.ByteBufList;
 

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/CompletionValue.java

@@ -72,7 +72,7 @@ void logOpResult(int rc) {
         }
 
         if (rc != BKException.Code.OK
-                && !PerChannelBookieClient.expectedBkOperationErrors.contains(rc)) {
+                && !PerChannelBookieClient.EXPECTED_BK_OPERATION_ERRORS.contains(rc)) {
             perChannelBookieClient.recordError();
         }
     }

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/GetListOfEntriesOfLedgerCompletion.java

@@ -22,6 +22,7 @@
 package org.apache.bookkeeper.proto;
 
 import static org.apache.bookkeeper.proto.BookkeeperInternalCallbacks.GetListOfEntriesOfLedgerCallback;
+
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import org.apache.bookkeeper.client.BKException;

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java

@@ -149,7 +149,7 @@ public class PerChannelBookieClient extends ChannelInboundHandlerAdapter {
     static final Logger LOG = LoggerFactory.getLogger(PerChannelBookieClient.class);
 
     // this set contains the bookie error return codes that we do not consider for a bookie to be "faulty"
-    protected static final Set<Integer> expectedBkOperationErrors = Collections.unmodifiableSet(Sets
+    protected static final Set<Integer> EXPECTED_BK_OPERATION_ERRORS = Collections.unmodifiableSet(Sets
             .newHashSet(BKException.Code.BookieHandleNotAvailableException,
                         BKException.Code.NoSuchEntryException,
                         BKException.Code.NoSuchLedgerExistsException,

bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadCompletion.java

@@ -22,6 +22,7 @@
 package org.apache.bookkeeper.proto;
 
 import static org.apache.bookkeeper.client.LedgerHandle.INVALID_ENTRY_ID;
+
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import io.netty.util.ReferenceCountUtil;
@@ -38,17 +39,12 @@ public ReadCompletion(final CompletionKey key,
         super("Read", originalCtx, ledgerId, entryId, perChannelBookieClient);
         this.opLogger = perChannelBookieClient.readEntryOpLogger;
         this.timeoutOpLogger = perChannelBookieClient.readTimeoutOpLogger;
-        this.cb = new BookkeeperInternalCallbacks.ReadEntryCallback() {
-            @Override
-            public void readEntryComplete(int rc, long ledgerId,
-                                          long entryId, ByteBuf buffer,
-                                          Object ctx) {
-                logOpResult(rc);
-                originalCallback.readEntryComplete(rc,
-                        ledgerId, entryId,
-                        buffer, originalCtx);
-                key.release();
-            }
+        this.cb = (rc, ledgerId1, entryId1, buffer, ctx) -> {
+            logOpResult(rc);
+            originalCallback.readEntryComplete(rc,
+                    ledgerId1, entryId1,
+                    buffer, originalCtx);
+            key.release();
         };
     }