fix(QTDI-2215): Add schema/Entry pojo. #1146
Conversation
|
ypiel-talend
left a comment
ypiel-talend
left a comment
There was a problem hiding this comment.
I may have misled you with the code generation for Schema/ Entry. We should simplify hem more. I think we need a builder etc... Simply need to be able to deserialize json->instance.
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> |
There was a problem hiding this comment.
Why this configuration has been added ?
| @Getter | ||
| private final Object internalDefaultValue; | ||
|
|
||
| @ConstructorProperties({"name", "rawName", "type", "nullable", "metadata", "errorCapable", |
There was a problem hiding this comment.
Is that needed ?
| if (this.name.equals(newValue)) { | ||
| return this; | ||
| } | ||
| return new Entry( |
There was a problem hiding this comment.
Is that really needed ? Maybe just simple setter ? what do you think ?
| if (this.rawName.equals(newValue)) { | ||
| return this; | ||
| } | ||
| return new Entry( |
There was a problem hiding this comment.
Is that really needed ? Maybe just simple setter ? what do you think ?
| if (this.type == newValue) { | ||
| return this; | ||
| } | ||
| return new Entry( |
| } | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
I think you can use lombok @DaTa it will automaticall y getter/setter/toString/hashCode et...
| .build(); | ||
| } | ||
|
|
||
| public static Builder builder() { |
There was a problem hiding this comment.
I don't think it is need. The goal is just to have a simple java POJO to desrialize a json to a java instance
|
|
||
| @Test | ||
| void deserializeEntryFromJson() throws Exception { | ||
| String json = """ |
There was a problem hiding this comment.
Maybe add component-runtime-impl in scope test, create entry/schema instances, then serialize them to json, and deserialize to the new class. We have to check it is compatible with Entry/Schema defined in component-runtime-impl at test test.
Requirements
Why this PR is needed?
What does this PR adds (design/code thoughts)?