Skip to content

Conversation

@jmfrancois
Copy link
Contributor

@jmfrancois jmfrancois commented Jan 9, 2026

What is the problem this PR is trying to solve?

The code is old so old.
We want to let it work with latest tooling like vite vitest, storybook.

What is the chosen solution to this problem?

JS is not supposed to contains any JSX code.
rename in JS any file that olds react code.

test:

  • look at playground
  • look at storybook
  • test (runned)

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2026

🦋 Changeset detected

Latest commit: 2a58ca0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@talend/react-faceted-search Major
@talend/react-storybook-cmf Major
@talend/react-cmf-router Major
@talend/react-components Major
@talend/react-containers Major
@talend/react-forms Major
@talend/react-a11y Major
@talend/react-cmf Major
@talend/scripts-config-jest Patch
@talend/react-faceted-search-query-client Major
@talend/ui-playground-vite Patch
@talend/ui-playground Patch
@talend/ui-storybook-one Patch
@talend/react-dataviz Patch
@talend/react-stepper Patch
@talend/react-cmf-cqrs Patch
@talend/react-sagas Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 10:04 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 12:15 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 12:16 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Title Lines Statements Branches Functions
assets-api Coverage: 28%
28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
89.36% (1243/1391) 80.93% (607/750) 89.51% (350/391)
cmf-cqrs Coverage: 87%
87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
90.63% (5517/6087) 81.59% (3196/3917) 88.14% (1390/1577)
containers Coverage: 84%
83.59% (1391/1664) 74.3% (694/934) 75% (327/436)
dataviz Coverage: 85%
85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 67%
66.49% (1016/1528) 50.93% (544/1068) 53.94% (219/406)
faceted-search Coverage: 85%
85.08% (639/751) 78.63% (287/365) 81.88% (226/276)
flow-designer Coverage: 70%
70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 86%
86.27% (1640/1901) 75.89% (929/1224) 85.02% (460/541)
http Coverage: 100%
100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
100% (73/73) 90.9% (10/11) 100% (24/24)

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 12:57 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 12:57 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 12:57 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Storybook for this PR deployed on this github page

Copy link
Contributor

@smouillour smouillour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-3000 lines, fix that bro

@lmaillet
Copy link
Contributor

lmaillet commented Jan 9, 2026

yarn test -u might help 😉

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 15:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 15:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 15:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe January 9, 2026 15:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois merged commit a525026 into master Jan 9, 2026
10 of 11 checks passed
@jmfrancois jmfrancois deleted the jmfrancois/fix/rename-jsx branch January 9, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants