Skip to content

feat(scripts): drop lint#5751

Merged
jmfrancois merged 3 commits intomasterfrom
jmfrancois/feat/drop-talend-script-lint
Mar 10, 2026
Merged

feat(scripts): drop lint#5751
jmfrancois merged 3 commits intomasterfrom
jmfrancois/feat/drop-talend-script-lint

Conversation

@jmfrancois
Copy link
Contributor

@jmfrancois jmfrancois commented Mar 10, 2026

What is the problem this PR is trying to solve?

talend-scripts must disappear.

Also we have a report from the previous release with this issue:

λ yarn lint:js
yarn run v1.22.22
$ eslint .

Oops! Something went wrong! :(

ESLint: 10.0.3

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'storybook' imported from PROJECT\node_modules\eslint-plugin-storybook\dist\index.js

What is the chosen solution to this problem?

  • remove talend-scripts lint command.
  • remove eslint-plugin-storybook from the shared config

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2026

🦋 Changeset detected

Latest commit: 3d8bad0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@talend/scripts-core Major
@talend/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 12:57 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 12:57 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Storybook for this PR deployed on this github page

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 13:06 — with GitHub Actions Inactive
@jmfrancois jmfrancois had a problem deploying to pull_request_unsafe March 10, 2026 13:06 — with GitHub Actions Failure
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 13:06 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Title Lines Statements Branches Functions
assets-api Coverage: 28%
28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 52%
50.63% (119/235) 26.98% (17/63) 28.91% (24/83)
cmf-cqrs Coverage: 86%
86.33% (158/183) 71.42% (60/84) 82.45% (47/57)
cmf-router Coverage: 70%
69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
90.77% (5577/6144) 82.41% (3228/3917) 88.21% (1400/1587)
containers Coverage: 84%
83.61% (1393/1666) 75.16% (702/934) 75.05% (328/437)
dataviz Coverage: 85%
85.71% (330/385) 65.28% (158/242) 75.94% (120/158)
design-system Coverage: 67%
67.03% (1041/1553) 51.95% (558/1074) 53.92% (220/408)
faceted-search Coverage: 85%
85.21% (634/744) 80% (292/365) 82.24% (227/276)
flow-designer Coverage: 73%
72.34% (675/933) 77.71% (415/534) 71.02% (201/283)
forms Coverage: 86%
86.17% (1645/1909) 76.71% (939/1224) 84.77% (462/545)
http Coverage: 100%
100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 81%
81.91% (154/188) 61.29% (57/93) 81.25% (39/48)
utils Coverage: 100%
100% (73/73) 90.9% (10/11) 100% (24/24)

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 13:28 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 16:14 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 16:14 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 16:14 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe March 10, 2026 16:14 — with GitHub Actions Inactive
@jmfrancois jmfrancois marked this pull request as ready for review March 10, 2026 16:15
@jmfrancois jmfrancois enabled auto-merge (squash) March 10, 2026 16:17
Copy link
Contributor

@lmaillet lmaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmfrancois jmfrancois merged commit 64e2fd5 into master Mar 10, 2026
10 checks passed
@jmfrancois jmfrancois deleted the jmfrancois/feat/drop-talend-script-lint branch March 10, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants