Skip to content

Conversation

@quent043
Copy link
Contributor

@quent043 quent043 commented Jun 8, 2023

PULL REQUEST CHECK LIST

  • If you have new .env variable, check if you add it in the .env.example file
  • Check if you have some prettier issues
  • Complete the README file with correct data if needed
  • if any changes have been made in contract, please update the abis

quent043 added 26 commits June 5, 2023 17:15
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
@quent043 quent043 requested a review from 0xRomain June 8, 2023 16:44
@vercel
Copy link

vercel bot commented Jun 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
indie ❌ Failed (Inspect) Jul 29, 2023 9:23am

Signed-off-by: Quentin D.C <[email protected]>
@quent043 quent043 added the NEED REVIEW Dev is waiting for peer review label Jun 16, 2023
next.config.js Outdated
images: {
domains: ['ipfs.io'],
domains: [
'ipfs.infura.io',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not cache these domains, and just use classic img component


//Store referrerId in local storage if any
if (router.query.referrerId) {
localStorage.setItem(`${service.id}-${user.id}`, router.query.referrerId as string);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be wrap in a useEffect

(service.referralAmount &&
(Number(localStorage.getItem(`${service.id}-${user.id}`)) ||
Number(router.query.referrerId as string) ||
Number(existingProposal?.referrer?.id))) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing value should be the first one used

): Promise<any> => {
try {
return await axios.post('/api/delegate/create-service', {
return await axios.post('/api/delegate/create-service-referral', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why renaming here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to remove this.

name: 'Matic',
decimals: 18,
},
'0xe6b8a5CF854791412c1f6EFC7CAf629f5Df1c747': {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why deleting this one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't working for me, I don't think it's been approved. I can put it back.

quent043 added 5 commits June 26, 2023 16:13
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Changed graph url

Signed-off-by: Quentin D.C <[email protected]>
quent043 added 4 commits July 28, 2023 21:40
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Signed-off-by: Quentin D.C <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NEED REVIEW Dev is waiting for peer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants