patch reduce_max and ConvertModel.forward retention of output activations#79
Open
sammlapp wants to merge 3 commits intoTalmaj:masterfrom
Open
patch reduce_max and ConvertModel.forward retention of output activations#79sammlapp wants to merge 3 commits intoTalmaj:masterfrom
sammlapp wants to merge 3 commits intoTalmaj:masterfrom
Conversation
otherwise we'll get a key error below when collecting activations for outputs, because we've removed an activation that is supposed to be included in the output
otherwise we'll get a key error below when collecting activations for outputs, because we've removed an activation that is supposed to be included in the output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were small patches that I needed to implement in order to convert an onnx model (link below) to PyTorch, as mentioned in #78
onnx model: https://huggingface.co/justinchuby/Perch-onnx/blob/main/perch_v2_no_dft.onnx
For what it's worth, I also had to modify the Pad and Reshape ConvertModel layers to avoid incorrect padding and reshaping behavior. I don't know if there is a generalizable fix to these issues.