Add channel storage page

[tudddorrr]

No description provided.

[claude]

PR Review: Add channel storage page

🟡 Code Quality and Best Practices

Issue 1: Inconsistent SWR key construction in useChannelStorage.ts:23

The SWR key includes both search and page separately, but the fetcher function only receives the URL. This means the fetcher doesn't actually use the updated search and page values from the SWR key.

// Current (incorrect)
const { data, error } = useSWR(
  [`/games/${activeGame.id}/game-channels/${channelId}/storage`, search, page],
  fetcher
)

Compare with useLeaderboardEntries.ts:40-44 which correctly includes all dependencies in both the key AND fetcher params.

Fix: The fetcher should receive all dependency values from the SWR key, or the search/page should be accessed from the closure (current approach works but is inconsistent with codebase patterns).

---

🟡 Potential Bugs or Issues

Issue 2: Missing null check for channelId in ChannelStorage.tsx:36

Using the non-null assertion operator (channelId!) and Number() without validation could cause issues if the route param is missing or invalid.

// Current (line 36)
useChannelStorage(activeGame, Number(channelId!), debouncedSearch, page)

While the 404 handling exists, Number(undefined) returns NaN which would make an invalid API request before the 404 is caught. Other pages like PlayerEvents.tsx:29 use the same pattern but pair it with validation hooks.

Fix: Add validation or use a default value to avoid NaN.

---

🔵 Performance Considerations

Issue 3: Empty dependency in Channels.tsx useEffect

Line 43-45 has a useEffect with editingChannel in the dependency array but it's never used in the effect body:

useEffect(() => {
  if (!showModal) setEditingChannel(null)
}, [showModal, editingChannel])  // editingChannel is unnecessary

This causes the effect to run on every editingChannel change even though it only needs showModal.

Fix: Remove editingChannel from the dependency array.

---

Security Concerns

No issues found

---

Overall: The PR follows the project patterns well. The main concerns are consistency with existing SWR hook patterns and a minor redundant dependency in useEffect. The functionality looks solid otherwise.