Skip to content

Improve channel storage UI#438

Merged
tudddorrr merged 1 commit intodevelopfrom
improve-channel-storage-ui
Dec 31, 2025
Merged

Improve channel storage UI#438
tudddorrr merged 1 commit intodevelopfrom
improve-channel-storage-ui

Conversation

@tudddorrr
Copy link
Collaborator

No description provided.

@tudddorrr tudddorrr added the enhancement New feature or request label Dec 31, 2025
@claude
Copy link

claude bot commented Dec 31, 2025

Code Review for PR #438

🔵 Code Quality - Minor

Inconsistent styling pattern (src/pages/ChannelStorage.tsx:97-100)

The new code wraps <code> inside a <span>, which differs from the existing pattern in Identifier.tsx:14:

// Existing pattern (Identifier.tsx)
<code className='bg-gray-900 rounded p-2 text-xs md:text-sm'>

// New pattern (ChannelStorage.tsx)
<span className='bg-gray-900 rounded text-xs flex'>
  <code className='align-middle inline-block p-2 break-all'>

While PropBadges.tsx uses a similar wrapper pattern, it serves a functional purpose (adding an action button). Here the extra <span> wrapper doesn't appear necessary. Consider applying styling directly to <code> to match the simpler pattern used in Identifier.tsx.


⚠️ Performance - Minor

Fixed width may cause table layout issues (src/pages/ChannelStorage.tsx:97)

Using both min-w-[400px] and max-w-[400px] creates a fixed 400px column that cannot shrink on smaller screens. The parent Table component has overflow-x-scroll (Table.tsx:14), but other cells in the row will still occupy space, potentially creating excessive horizontal scrolling on mobile devices.

Consider:

  • Using only min-w-[400px] (like PropsEditor.tsx:164) and allowing growth
  • Or adding responsive classes like lg:min-w-0 (like Groups.tsx:126) for better mobile UX

Security, Bugs

No issues found.

@tudddorrr tudddorrr merged commit 192fb84 into develop Dec 31, 2025
5 checks passed
@tudddorrr tudddorrr deleted the improve-channel-storage-ui branch December 31, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant